You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "t99-i (via GitHub)" <gi...@apache.org> on 2026/07/19 16:32:13 UTC
[PR] [SYSTEMDS-3857] set get names on frame [systemds]
t99-i opened a new pull request, #2558:
URL: https://github.com/apache/systemds/pull/2558
This PR adds the frame operations getNames and setNames.
Changes:
Added getNames support in compiler, CP and Spark runtime
Added setNames support in compiler, CP and Spark runtime
Added tests for getNames and setNames
Updated DML language reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3857] set get names on frame [systemds]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2558:
URL: https://github.com/apache/systemds/pull/2558#issuecomment-5055904369
## [Codecov](https://app.codecov.io/gh/apache/systemds/pull/2558?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `84.84848%` with `10 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 71.63%. Comparing base ([`e4f0987`](https://app.codecov.io/gh/apache/systemds/commit/e4f09873865f904bfc53f8eb63e47083c1ad21ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fead95b`](https://app.codecov.io/gh/apache/systemds/commit/fead95b9f734a14f1b313d606b47dfd0047f3dc5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 53 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/systemds/pull/2558?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...instructions/cp/BinaryFrameFrameCPInstruction.java](https://app.codecov.io/gh/apache/systemds/pull/2558?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Finstructions%2Fcp%2FBinaryFrameFrameCPInstruction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvaW5zdHJ1Y3Rpb25zL2NwL0JpbmFyeUZyYW1lRnJhbWVDUEluc3RydWN0aW9uLmphdmE=) | 60.00% | [5 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/sysds/runtime/instructions/InstructionUtils.java](https://app.codecov.io/gh/apache/systemds/pull/2558?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Finstructions%2FInstructionUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvaW5zdHJ1Y3Rpb25zL0luc3RydWN0aW9uVXRpbHMuamF2YQ==) | 50.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2558 +/- ##
============================================
+ Coverage 71.47% 71.63% +0.16%
- Complexity 48883 50162 +1279
============================================
Files 1573 1614 +41
Lines 189238 194052 +4814
Branches 37128 37944 +816
============================================
+ Hits 135261 139017 +3756
- Misses 43530 44122 +592
- Partials 10447 10913 +466
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/systemds/pull/2558?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3857] set get names on frame [systemds]
Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 commented on PR #2558:
URL: https://github.com/apache/systemds/pull/2558#issuecomment-6363979772
Thanks @t99-i for your contribution. In the next few weeks I'll take it over, finalize it, and then merge it in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org