You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by JiangJiafu <gi...@git.apache.org> on 2017/05/14 02:16:59 UTC
[GitHub] zookeeper pull request #253: ZOOKEEPER-2774
GitHub user JiangJiafu opened a pull request:
https://github.com/apache/zookeeper/pull/253
ZOOKEEPER-2774
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JiangJiafu/zookeeper ZOOKEEPER-2774
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/253.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #253
----
commit 3ac65ead39fad4f8d9f26365e1bc73f83889f11e
Author: Jiang Jiafu <ji...@gmail.com>
Date: 2017-05-13T03:41:52Z
ZOOKEEPER-2774
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #253: ZOOKEEPER-2774
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/253
LGTM - all unit test passed. The Jenkins check failed because it has findbug warnings and that is a known issue for branch-3.4. I will merge this to branch-3.4 soon.
One suggestion, in future pull request, please provide a descriptive title and a brief description of what the pull request did.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #253: ZOOKEEPER-2774
Posted by JiangJiafu <gi...@git.apache.org>.
Github user JiangJiafu commented on the issue:
https://github.com/apache/zookeeper/pull/253
Thanks for your review work. @afine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #253: ZOOKEEPER-2774
Posted by JiangJiafu <gi...@git.apache.org>.
Github user JiangJiafu commented on the issue:
https://github.com/apache/zookeeper/pull/253
Port the code from ZOOKEEPER-1366 to branch3.4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #253: ZOOKEEPER-2774
Posted by JiangJiafu <gi...@git.apache.org>.
Github user JiangJiafu commented on the issue:
https://github.com/apache/zookeeper/pull/253
Thanks for your work @hanm @afine .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #253: ZOOKEEPER-2774
Posted by JiangJiafu <gi...@git.apache.org>.
Github user JiangJiafu commented on the issue:
https://github.com/apache/zookeeper/pull/253
Code has bee changed according to your advice. @hanm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #253: ZOOKEEPER-2774
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/253
* Missing changes to ClientBase.java and QuorumPeerMainTest.java.
* File TimeTest.java is not missing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #253: ZOOKEEPER-2774
Posted by JiangJiafu <gi...@git.apache.org>.
Github user JiangJiafu commented on the issue:
https://github.com/apache/zookeeper/pull/253
It seems like now the unit tests are ok.
I don't know what is the problems now? @hanm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #253: ZOOKEEPER-2774
Posted by JiangJiafu <gi...@git.apache.org>.
Github user JiangJiafu closed the pull request at:
https://github.com/apache/zookeeper/pull/253
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #253: ZOOKEEPER-2774
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/253
Patch lgtm, almost there!
There is one test failure in pre-commit build (see 'All checks have failed' - Details)
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/698/testReport/
org.apache.zookeeper.test.ReadOnlyModeTest.testConnectionEvents
This test was not failing without this patch, and (consistently) failing with the patch on Apache Jenkins. Please investigate. Generally we'd like have a green pre-commit build before merging a PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #253: ZOOKEEPER-2774
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/253
Merged to branch-3.4. Please close this pull request, @JiangJiafu.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #253: ZOOKEEPER-2774
Posted by afine <gi...@git.apache.org>.
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/253#discussion_r116588671
--- Diff: src/java/main/org/apache/zookeeper/ZKUtil.java ---
@@ -120,5 +120,4 @@ public static void deleteRecursive(ZooKeeper zk, final String pathRoot, VoidCall
}
return tree;
}
-
-}
\ No newline at end of file
+}
--- End diff --
unnecessary change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #253: ZOOKEEPER-2774
Posted by JiangJiafu <gi...@git.apache.org>.
Github user JiangJiafu commented on the issue:
https://github.com/apache/zookeeper/pull/253
@hanm, do you mean that all the test souce files code should be changed if they use System.currentTimeMillis()?
Or do you mean that I should just change these two files: ClientBase.java and QuorumPeerMainTest.java?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---