[GitHub] eolivelli commented on a change in pull request #1452: [table service] remove StorageContainerRequest and StorageContainerResponse

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1452: [table service] remove StorageContainerRequest and StorageContainerResponse
URL: https://github.com/apache/bookkeeper/pull/1452#discussion_r191401703
 
 

 ##########
 File path: stream/proto/src/main/proto/kv_rpc.proto
 ##########
 @@ -47,28 +48,25 @@ service KV {
   // DeleteRange deletes the given range from the key-value store.
   // A delete request increments the revision of the key-value store
   // and generates a delete event in the event history for every deleted key.
-  rpc DeleteRange(DeleteRangeRequest) returns (DeleteRangeResponse) {}
+  rpc Delete(DeleteRangeRequest) returns (DeleteRangeResponse) {}
 
   // Txn processes multiple requests in a single transaction.
   // A txn request increments the revision of the key-value store
   // and generates events with the same revision for every completed request.
   // It is not allowed to modify the same key several times within one txn.
   rpc Txn(TxnRequest) returns (TxnResponse) {}
 
+  // Increment increments the amount associated with the keys
+  rpc Increment(IncrementRequest) returns (IncrementResponse) {}
+
 }
 
 message ResponseHeader {
-  // cluster_id is the ID of the cluster which sent the response.
-  uint64 cluster_id = 1;
-  // member_id is the ID of the member which sent the response.
-  uint64 member_id = 2;
-  // revision is the key-value store revision when the request was applied.
-  int64 revision = 3;
-  // raft_term is the raft term when the request was applied.
-  uint64 raft_term = 4;
+  // Status Code
+  storage.StatusCode code               = 1;
 
   // routing header
-  RoutingHeader routing_header = 99;
+  RoutingHeader routing_header  = 99;
 }
 
 Review comment:
   Nit: remove space

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services