Re: BEEHIVE-1122 and ability to show all records in a data set

[Eddie O'Neil <ek...@gmail.com>]

Carlin--

  Thanks for resolving this -- I agree with you that the showAll
attribute should do the trick.

  As far as setting disableDefaultPager="true", I'd leave this as-is
since it would be useful to display a message like "Page 1 of 1".
It's also probably easier to figure out how to turn the pager off than
it is to figure out why it was automagically disabled and then
re-enable it.  My $0.02.

Cheers,
Eddie


On Oct 16, 2007 11:42 PM, Carlin Rogers <ca...@gmail.com> wrote:
> Eddie,
>
> I tested the code changes for the new showAll showAll attribute in the
> <netui-data:configurePager> tag and think that solves the issue for
> BEEHIVE-1122. I'm going to go ahead and resolve it as well. If anyone
> disagrees, please reopen the issue in JIRA.
>
> The only thought I had was that if someone has showAll="true", maybe
> the configurePager tag should default to have
> disableDefaultPager="true". That way the user does not have to
> explicitly have to set it in the tag to keep the pager links from
> appearing. What do you think? I can make the change if you think that
> sounds correct.
>
> Thanks,
> Carlin
>
>
> On 10/3/07, Carlin Rogers <ca...@gmail.com> wrote:
> > Hi Eddie,
> >
> > Looks like there's another enhancement request can also be closed with
> > the work you submitted in svn revision 431515. The change to the
> > SpanCellDecorator to check if the formatted string is null, then
> > assign an empty string instead, solves the issue in      BEEHIVE-1121 to
> > add defaultValue to the spanCell tag. I will go ahead and resolve
> > BEEHIVE-1121. If this is not correct, please feel free to reopen.
> >
> > Let me know what you think about resolving 1122 as well.
> >
> > Take care,
> > Carlin
> >
> > On 9/28/07, Carlin Rogers <ca...@gmail.com> wrote:
> > > Hi Eddie,
> > >
> > > I have a question about a NetUI data-grid enhancement, BEEHIVE-1122.
> > >
> > > Early this month there was a question in the user list about the
> > > ability to show all records in a data set to the data grid. I noted
> > > you did some work on this when you checked in a solution for another
> > > bug, BEEHIVE-1102, for partial data set support. BEEHIVE-1102 has been
> > > resolved but I was wondering if BEEHIVE-1122 should also be resolved.
> > > I see that there is also a test that uses the new showAll attribute in
> > > the <netui-data:configurePager> tag. Seems like this is complete. FYI,
> > > this work was part of svn revision 431515.
> > >
> > > Can I resolve this for you?
> > >
> > > Thanks,
> > > Carlin
> > >
> >
>

Re: BEEHIVE-1122 and ability to show all records in a data set

[Carlin Rogers <ca...@gmail.com>]

Eddie,

OK, leaving the configurePager tag as is sounds good. Thanks for the feedback.

Carlin

On 11/20/07, Eddie O'Neil <ek...@gmail.com> wrote:
> Carlin--
>
>   Thanks for resolving this -- I agree with you that the showAll
> attribute should do the trick.
>
>   As far as setting disableDefaultPager="true", I'd leave this as-is
> since it would be useful to display a message like "Page 1 of 1".
> It's also probably easier to figure out how to turn the pager off than
> it is to figure out why it was automagically disabled and then
> re-enable it.  My $0.02.
>
> Cheers,
> Eddie
>
>
> On Oct 16, 2007 11:42 PM, Carlin Rogers <ca...@gmail.com> wrote:
> > Eddie,
> >
> > I tested the code changes for the new showAll showAll attribute in the
> > <netui-data:configurePager> tag and think that solves the issue for
> > BEEHIVE-1122. I'm going to go ahead and resolve it as well. If anyone
> > disagrees, please reopen the issue in JIRA.
> >
> > The only thought I had was that if someone has showAll="true", maybe
> > the configurePager tag should default to have
> > disableDefaultPager="true". That way the user does not have to
> > explicitly have to set it in the tag to keep the pager links from
> > appearing. What do you think? I can make the change if you think that
> > sounds correct.
> >
> > Thanks,
> > Carlin
> >
> >
> > On 10/3/07, Carlin Rogers <ca...@gmail.com> wrote:
> > > Hi Eddie,
> > >
> > > Looks like there's another enhancement request can also be closed with
> > > the work you submitted in svn revision 431515. The change to the
> > > SpanCellDecorator to check if the formatted string is null, then
> > > assign an empty string instead, solves the issue in      BEEHIVE-1121 to
> > > add defaultValue to the spanCell tag. I will go ahead and resolve
> > > BEEHIVE-1121. If this is not correct, please feel free to reopen.
> > >
> > > Let me know what you think about resolving 1122 as well.
> > >
> > > Take care,
> > > Carlin
> > >
> > > On 9/28/07, Carlin Rogers <ca...@gmail.com> wrote:
> > > > Hi Eddie,
> > > >
> > > > I have a question about a NetUI data-grid enhancement, BEEHIVE-1122.
> > > >
> > > > Early this month there was a question in the user list about the
> > > > ability to show all records in a data set to the data grid. I noted
> > > > you did some work on this when you checked in a solution for another
> > > > bug, BEEHIVE-1102, for partial data set support. BEEHIVE-1102 has been
> > > > resolved but I was wondering if BEEHIVE-1122 should also be resolved.
> > > > I see that there is also a test that uses the new showAll attribute in
> > > > the <netui-data:configurePager> tag. Seems like this is complete. FYI,
> > > > this work was part of svn revision 431515.
> > > >
> > > > Can I resolve this for you?
> > > >
> > > > Thanks,
> > > > Carlin
> > > >
> > >
> >
>