You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Barry Oglesby <bo...@pivotal.io> on 2016/02/01 19:12:50 UTC
Re: Review Request 42977: GEODE-875: CI failure:
ParallelGatewaySenderOperationsOffHeapDUnitTest.testParallelGatewaySender_SingleNode_UserPR_localDestroy_SimultenuousPut_RecreateRegion
> On Jan. 29, 2016, 10:46 p.m., xiaojian zhou wrote:
> > gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java, line 631
> > <https://reviews.apache.org/r/42977/diff/1/?file=1225947#file1225947line631>
> >
> > I also think we can make these "ln" as parameter and make the method more generic.
> >
> > Any way, others look good, you can ship it.
Thanks. Yes, thats definitely true. There are a lot of other parameters like that in both createSender and createSenders. I've only added method parameters for values that are currently different for different callers. If a future test needs to parameterize the sender id, we can parameterize that value as well.
- Barry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42977/#review117038
-----------------------------------------------------------
On Jan. 29, 2016, 9:34 p.m., Barry Oglesby wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42977/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 9:34 p.m.)
>
>
> Review request for geode, Dan Smith and xiaojian zhou.
>
>
> Bugs: GEODE-875
> https://issues.apache.org/jira/browse/GEODE-875
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-875: CI failure: ParallelGatewaySenderOperationsOffHeapDUnitTest.testParallelGatewaySender_SingleNode_UserPR_localDestroy_SimultenuousPut_RecreateRegion
>
> - deleted testParallelGatewaySender_SingleNode_UserPR_localDestroy_SimultenuousPut_RecreateRegion (useless test)
> - removed all methods from ParallelGatewaySenderOperationsDUnitTest that are similar to ConcurrentParallelGatewaySenderOperation_2_DUnitTest
> - extended ConcurrentParallelGatewaySenderOperation_2_DUnitTest with ParallelGatewaySenderOperation_2_DUnitTest for these removed methods with overridden implementations of createSender and createSenders
> - extended ConcurrentParallelGatewaySenderOperation_2_DUnitTest with ConcurrentParallelGatewaySenderOperation_2_OffHeapDUnitTest with overridden implementation of isOffHeap
> - extended ParallelGatewaySenderOperation_2_DUnitTest with ParallelGatewaySenderOperation_2_OffHeapDUnitTest with overridden implementation of isOffHeap
>
>
> Diffs
> -----
>
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java a212baa68b05e6fae3262f582340e71b1a7e69a5
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java 694fc1f93d8fdccaf02abe11d2b780d8d12a1c07
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/ConcurrentParallelGatewaySenderOperation_2_OffHeapDUnitTest.java PRE-CREATION
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/ParallelGatewaySenderOperation_2_OffHeapDUnitTest.java PRE-CREATION
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderOperation_2_DUnitTest.java PRE-CREATION
> gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderOperationsDUnitTest.java 19f6c4bf559b9238f369aaa06c4b8594a3439497
>
> Diff: https://reviews.apache.org/r/42977/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Barry Oglesby
>
>