You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <mo...@yahoo.in> on 2012/12/20 21:11:47 UTC
Review Request: OOZIE-1141 Escaping Ampersand in the HCat URI to bypass XML
validation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8726/
-----------------------------------------------------------
Review request for oozie.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1141
WIP
This addresses bug OOZIE-1141.
https://issues.apache.org/jira/browse/OOZIE-1141
Diffs
-----
branches/hcat-intre/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1424233
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 1424233
branches/hcat-intre/core/src/main/java/org/apache/oozie/util/XmlUtils.java 1424233
branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestXmlUtils.java 1424233
Diff: https://reviews.apache.org/r/8726/diff/
Testing
-------
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1141 Escaping Ampersand in the HCat URI to bypass
XML validation
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8726/#review14784
-----------------------------------------------------------
Let's wait on Tucu's comments. Having a invalid xml as a specially supported case of input to oozie doesn't look good and we should avoid doing things non-standard.
branches/hcat-intre/core/src/main/java/org/apache/oozie/util/XmlUtils.java
<https://reviews.apache.org/r/8726/#comment31348>
Blind replace will cause problems if user puts & in the xml somewhere.
- Rohini Palaniswamy
On Dec. 20, 2012, 8:11 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8726/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2012, 8:11 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1141
> WIP
>
>
> This addresses bug OOZIE-1141.
> https://issues.apache.org/jira/browse/OOZIE-1141
>
>
> Diffs
> -----
>
> branches/hcat-intre/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1424233
> branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 1424233
> branches/hcat-intre/core/src/main/java/org/apache/oozie/util/XmlUtils.java 1424233
> branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestXmlUtils.java 1424233
>
> Diff: https://reviews.apache.org/r/8726/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mona Chitnis
>
>