[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5146: Update pinot assembly scripts for release 0.3.0

[GitBox <gi...@apache.org>]

fx19880617 commented on a change in pull request #5146: Update pinot assembly scripts for release 0.3.0
URL: https://github.com/apache/incubator-pinot/pull/5146#discussion_r391854918
 
 

 ##########
 File path: pinot-distribution/pinot-assembly.xml
 ##########
 @@ -43,10 +43,74 @@
     <file>
       <source>${pinot.root}/DISCLAIMER</source>
     </file>
+    <!-- Include Pinot All-in-one jar -->
     <file>
       <source>${pinot.root}/pinot-distribution/target/pinot-distribution-${project.version}-shaded.jar</source>
       <destName>lib/pinot-all-${project.version}-jar-with-dependencies.jar</destName>
     </file>
+    <!-- Start Include Pinot Plugins-->
+    <!-- Start Include Pinot Stream Ingestion Plugins-->
+    <!-- Only Include Specified Kafka Version Plugin-->
+    <file>
+      <source>${pinot.root}/pinot-plugins/pinot-stream-ingestion/pinot-kafka-${kafka.version}/target/pinot-kafka-${kafka.version}-${project.version}-shaded.jar</source>
 
 Review comment:
   That is how we did it previously by gathering all the jars together then copy directory, see line `<outputDirectory>${pinot.root}/pinot-plugins/target/plugins/${plugin.type}/${project.artifactId}</outputDirectory>` in `pinot-plugins/pom.xml`.
   
   However `mvn release` doesn't honor this, and cannot find the built jars if we relocated them, that's why we need to hand-pick all those jars again here. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org