You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2024/11/21 00:53:45 UTC
[Impala-ASF-CR] Prototype: Workaround Python 2 tarfile issue by patching tarfile.py
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22088
Change subject: Prototype: Workaround Python 2 tarfile issue by patching tarfile.py
......................................................................
Prototype: Workaround Python 2 tarfile issue by patching tarfile.py
Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
---
M bin/bootstrap_system.sh
1 file changed, 17 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/22088/1
--
To view, visit http://gerrit.cloudera.org:8080/22088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
Gerrit-Change-Number: 22088
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22088 )
Change subject: IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11154/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
Gerrit-Change-Number: 22088
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 01:33:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22088
to look at the new patch set (#3).
Change subject: IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
......................................................................
IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
Ubuntu 20.04 introduced a bug in their Python 2.7's tarfile
functionality with 2.7.18-1~20.04.5. See
https://bugs.launchpad.net/ubuntu/+source/python2.7/+bug/2089071
This breaks the Impala build with a message like
"tarfile.ReadError: invalid header".
The bug has an attached tarfile.py with a workaround for the
issue. This change bootstrap_system.sh and boostrap_build.sh to
detect the bad tarfile.py and replace it with the patched tarfile.py.
Since this is comparing the hash, this will become a no-op once
Ubuntu fixes the issue.
Testing:
- Ran a build on Ubuntu 20.04
Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
---
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
2 files changed, 33 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/22088/3
--
To view, visit http://gerrit.cloudera.org:8080/22088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
Gerrit-Change-Number: 22088
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22088 )
Change subject: IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/17523/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/22088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
Gerrit-Change-Number: 22088
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 01:20:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22088 )
Change subject: IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
......................................................................
Patch Set 4: Code-Review+2
LGTM. Merging this to unblock builds.
--
To view, visit http://gerrit.cloudera.org:8080/22088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
Gerrit-Change-Number: 22088
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 03:35:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Prototype: Workaround Python 2 tarfile issue by patching tarfile.py
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22088
to look at the new patch set (#2).
Change subject: Prototype: Workaround Python 2 tarfile issue by patching tarfile.py
......................................................................
Prototype: Workaround Python 2 tarfile issue by patching tarfile.py
Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
---
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
2 files changed, 33 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/22088/2
--
To view, visit http://gerrit.cloudera.org:8080/22088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
Gerrit-Change-Number: 22088
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22088 )
Change subject: IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22088/4/bin/bootstrap_build.sh
File bin/bootstrap_build.sh:
http://gerrit.cloudera.org:8080/#/c/22088/4/bin/bootstrap_build.sh@50
PS4, Line 50: wget -nv https://launchpadlibrarian.net/759546541/tarfile.py
> I guess this is owned by Canonical. As a short-term patch, I'll live with i
I hope the number "759546541" in the URL is unique for the attachment file. We can fix it later if it's not.
--
To view, visit http://gerrit.cloudera.org:8080/22088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
Gerrit-Change-Number: 22088
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 07:55:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22088 )
Change subject: IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/17526/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
Gerrit-Change-Number: 22088
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 01:39:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22088
to look at the new patch set (#4).
Change subject: IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
......................................................................
IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
Ubuntu 20.04 introduced a bug in their Python 2.7's tarfile
functionality with 2.7.18-1~20.04.5. See
https://bugs.launchpad.net/ubuntu/+source/python2.7/+bug/2089071
This breaks the Impala build with a message like
"tarfile.ReadError: invalid header".
The bug has an attached tarfile.py with a workaround for the
issue. This change bootstrap_system.sh and boostrap_build.sh to
detect the bad tarfile.py and replace it with the patched tarfile.py.
Since this is comparing the hash, this will become a no-op once
Ubuntu fixes the issue.
Testing:
- Ran a build on Ubuntu 20.04
Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
---
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
2 files changed, 32 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/22088/4
--
To view, visit http://gerrit.cloudera.org:8080/22088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
Gerrit-Change-Number: 22088
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22088 )
Change subject: IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/17527/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
Gerrit-Change-Number: 22088
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 01:48:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22088 )
Change subject: IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
Gerrit-Change-Number: 22088
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 06:55:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22088 )
Change subject: IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22088/4/bin/bootstrap_build.sh
File bin/bootstrap_build.sh:
http://gerrit.cloudera.org:8080/#/c/22088/4/bin/bootstrap_build.sh@50
PS4, Line 50: wget -nv https://launchpadlibrarian.net/759546541/tarfile.py
I'm wary of downloading from this source without hash verification. Can we check this file in?
--
To view, visit http://gerrit.cloudera.org:8080/22088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
Gerrit-Change-Number: 22088
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 04:06:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22088 )
Change subject: IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
......................................................................
IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
Ubuntu 20.04 introduced a bug in their Python 2.7's tarfile
functionality with 2.7.18-1~20.04.5. See
https://bugs.launchpad.net/ubuntu/+source/python2.7/+bug/2089071
This breaks the Impala build with a message like
"tarfile.ReadError: invalid header".
The bug has an attached tarfile.py with a workaround for the
issue. This change bootstrap_system.sh and boostrap_build.sh to
detect the bad tarfile.py and replace it with the patched tarfile.py.
Since this is comparing the hash, this will become a no-op once
Ubuntu fixes the issue.
Testing:
- Ran a build on Ubuntu 20.04
Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
Reviewed-on: http://gerrit.cloudera.org:8080/22088
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
2 files changed, 32 insertions(+), 0 deletions(-)
Approvals:
Quanlong Huang: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/22088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
Gerrit-Change-Number: 22088
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22088 )
Change subject: IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22088/4/bin/bootstrap_build.sh
File bin/bootstrap_build.sh:
http://gerrit.cloudera.org:8080/#/c/22088/4/bin/bootstrap_build.sh@50
PS4, Line 50: wget -nv https://launchpadlibrarian.net/759546541/tarfile.py
> I hope the number "759546541" in the URL is unique for the attachment file.
I'm happy to add hash verification. That's easy. I'm hoping that Ubuntu fixes this quickly and we'll end up ripping this out pretty soon.
--
To view, visit http://gerrit.cloudera.org:8080/22088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
Gerrit-Change-Number: 22088
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 17:07:08 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22088 )
Change subject: IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/17524/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
Gerrit-Change-Number: 22088
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 01:21:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22088 )
Change subject: IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
......................................................................
Patch Set 4:
will wait for job https://jenkins.impala.io/job/gerrit-verify-dryrun/11154 to finish
--
To view, visit http://gerrit.cloudera.org:8080/22088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
Gerrit-Change-Number: 22088
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 03:36:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22088 )
Change subject: IMPALA-13558: Workaround Python 2 tarfile issue by patching tarfile.py
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22088/4/bin/bootstrap_build.sh
File bin/bootstrap_build.sh:
http://gerrit.cloudera.org:8080/#/c/22088/4/bin/bootstrap_build.sh@50
PS4, Line 50: wget -nv https://launchpadlibrarian.net/759546541/tarfile.py
> I'm wary of downloading from this source without hash verification. Can we
I guess this is owned by Canonical. As a short-term patch, I'll live with it.
--
To view, visit http://gerrit.cloudera.org:8080/22088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d0691611cf53ae6dd1099b97f0aa15b450e0996
Gerrit-Change-Number: 22088
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 04:07:42 +0000
Gerrit-HasComments: Yes