[GitHub] [airflow] KevinYang21 commented on a change in pull request #5615: [AIRFLOW-5035] Remove multiprocessing.Manager in-favour of Pipes

[GitBox <gi...@apache.org>]

KevinYang21 commented on a change in pull request #5615: [AIRFLOW-5035] Remove multiprocessing.Manager in-favour of Pipes
URL: https://github.com/apache/airflow/pull/5615#discussion_r307941368
 
 

 ##########
 File path: airflow/utils/dag_processing.py
 ##########
 @@ -504,134 +508,148 @@ def __init__(self,
         # Pids of DAG parse
         self._all_pids = []
         # Pipe for communicating signals
-        self._parent_signal_conn, self._child_signal_conn = multiprocessing.Pipe()
-        # Pipe for communicating DagParsingStat
-        self._manager = multiprocessing.Manager()
-        self._stat_queue = self._manager.Queue()
-        self._result_queue = self._manager.Queue()
         self._process = None
         self._done = False
         # Initialized as true so we do not deactivate w/o any actual DAG parsing.
         self._all_files_processed = True
         self._result_count = 0
 
 Review comment:
   we should be able to remove `self._result_count` given this [PR](https://github.com/apache/airflow/pull/5167)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services