[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #4187: [TimeZone]Set UTC to defult timezone

[GitBox <gi...@apache.org>]

HangyuanLiu commented on a change in pull request #4187:
URL: https://github.com/apache/incubator-doris/pull/4187#discussion_r461542445



##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/util/TimeUtils.java
##########
@@ -256,7 +256,7 @@ public static String checkTimeZoneValidAndStandardize(String value) throws DdlEx
             Matcher matcher = TIMEZONE_OFFSET_FORMAT_REG.matcher(value);
             // it supports offset and region timezone type, "CST" use here is compatibility purposes.
             boolean match = matcher.matches();
-            if (!value.contains("/") && !value.equals("CST") && !match) {
+            if (!value.contains("/") && !value.equals("CST") && !value.equals("UTC") && !match) {

Review comment:
       Yes.  the time zone represented by this time zone abbreviation may be uncertain.
   Another reason is the timezone string may transfer to be, the library of timezone in be may not support short time zone.
   So may be you should test UTC can run correctly in be time function ,such as from_unixtime




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org