You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Zoltan Chovan (Code Review)" <ge...@cloudera.org> on 2024/11/07 12:17:11 UTC
[kudu-CR] Revert "[rest] add oat++ framework to kudu"
Zoltan Chovan has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22040
Change subject: Revert "[rest] add oat++ framework to kudu"
......................................................................
Revert "[rest] add oat++ framework to kudu"
This reverts commit dda258785bbdfef8a14bc27c7cb1c9ebd61d3035.
Since the Oat++ framework was never used in any features, and the Oat++
based rest api was abandoned, this revert removes the library as a
dependency.
Change-Id: Ie589074b67ed5ed23d4f83ccea8e3351caef5e7f
---
M CMakeLists.txt
D cmake_modules/FindOatpp.cmake
D cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
D thirdparty/patches/oatpp-remove-version-from-path.patch
D thirdparty/patches/oatpp-swagger-remove-version-from-path.patch
M thirdparty/vars.sh
9 files changed, 0 insertions(+), 306 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/22040/1
--
To view, visit http://gerrit.cloudera.org:8080/22040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie589074b67ed5ed23d4f83ccea8e3351caef5e7f
Gerrit-Change-Number: 22040
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] Revert "[rest] add oat++ framework to kudu"
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22040 )
Change subject: Revert "[rest] add oat++ framework to kudu"
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/710/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie589074b67ed5ed23d4f83ccea8e3351caef5e7f
Gerrit-Change-Number: 22040
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Nov 2024 12:49:30 +0000
Gerrit-HasComments: No
[kudu-CR] Revert "[rest] add oat++ framework to kudu"
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22040 )
Change subject: Revert "[rest] add oat++ framework to kudu"
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/813/
--
To view, visit http://gerrit.cloudera.org:8080/22040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie589074b67ed5ed23d4f83ccea8e3351caef5e7f
Gerrit-Change-Number: 22040
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2024 17:50:59 +0000
Gerrit-HasComments: No
[kudu-CR] Revert "[rest] add oat++ framework to kudu"
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22040 )
Change subject: Revert "[rest] add oat++ framework to kudu"
......................................................................
Patch Set 2: -Verified
Build Started http://jenkins.kudu.apache.org/job/pre_commit/883/
--
To view, visit http://gerrit.cloudera.org:8080/22040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie589074b67ed5ed23d4f83ccea8e3351caef5e7f
Gerrit-Change-Number: 22040
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Dec 2024 13:27:58 +0000
Gerrit-HasComments: No
[kudu-CR] Revert "[rest] add oat++ framework to kudu"
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22040 )
Change subject: Revert "[rest] add oat++ framework to kudu"
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/813/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie589074b67ed5ed23d4f83ccea8e3351caef5e7f
Gerrit-Change-Number: 22040
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2024 18:50:07 +0000
Gerrit-HasComments: No
[kudu-CR] Revert "[rest] add oat++ framework to kudu"
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/22040 )
Change subject: Revert "[rest] add oat++ framework to kudu"
......................................................................
Patch Set 1:
i want to check the ci results.
re-triggered the build as the old one expired.
--
To view, visit http://gerrit.cloudera.org:8080/22040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie589074b67ed5ed23d4f83ccea8e3351caef5e7f
Gerrit-Change-Number: 22040
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Nov 2024 11:45:17 +0000
Gerrit-HasComments: No
[kudu-CR] Revert "[rest] add oat++ framework to kudu"
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22040 )
Change subject: Revert "[rest] add oat++ framework to kudu"
......................................................................
Revert "[rest] add oat++ framework to kudu"
This reverts commit dda258785bbdfef8a14bc27c7cb1c9ebd61d3035.
Since the Oat++ framework was never used in any features, and the Oat++
based rest api was abandoned, this revert removes the library as a
dependency.
Change-Id: Ie589074b67ed5ed23d4f83ccea8e3351caef5e7f
Reviewed-on: http://gerrit.cloudera.org:8080/22040
Reviewed-by: Marton Greber <gr...@gmail.com>
Tested-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Gabriella Lotz <lo...@gmail.com>
---
M CMakeLists.txt
D cmake_modules/FindOatpp.cmake
D cmake_modules/FindOatppSwagger.cmake
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
D thirdparty/patches/oatpp-remove-version-from-path.patch
D thirdparty/patches/oatpp-swagger-remove-version-from-path.patch
M thirdparty/vars.sh
9 files changed, 0 insertions(+), 306 deletions(-)
Approvals:
Marton Greber: Looks good to me, approved; Verified
Gabriella Lotz: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/22040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie589074b67ed5ed23d4f83ccea8e3351caef5e7f
Gerrit-Change-Number: 22040
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] Revert "[rest] add oat++ framework to kudu"
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22040 )
Change subject: Revert "[rest] add oat++ framework to kudu"
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/671/
--
To view, visit http://gerrit.cloudera.org:8080/22040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie589074b67ed5ed23d4f83ccea8e3351caef5e7f
Gerrit-Change-Number: 22040
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 07 Nov 2024 12:17:18 +0000
Gerrit-HasComments: No
[kudu-CR] Revert "[rest] add oat++ framework to kudu"
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22040 )
Change subject: Revert "[rest] add oat++ framework to kudu"
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/671/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie589074b67ed5ed23d4f83ccea8e3351caef5e7f
Gerrit-Change-Number: 22040
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Nov 2024 13:30:36 +0000
Gerrit-HasComments: No
[kudu-CR] Revert "[rest] add oat++ framework to kudu"
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22040 )
Change subject: Revert "[rest] add oat++ framework to kudu"
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/883/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie589074b67ed5ed23d4f83ccea8e3351caef5e7f
Gerrit-Change-Number: 22040
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Dec 2024 15:17:07 +0000
Gerrit-HasComments: No
[kudu-CR] Revert "[rest] add oat++ framework to kudu"
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/22040 )
Change subject: Revert "[rest] add oat++ framework to kudu"
......................................................................
Patch Set 2: Verified+1 Code-Review+2
unrelated java test failure: tsan, org.apache.kudu.client.TestKuduClient
--
To view, visit http://gerrit.cloudera.org:8080/22040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie589074b67ed5ed23d4f83ccea8e3351caef5e7f
Gerrit-Change-Number: 22040
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Dec 2024 10:00:59 +0000
Gerrit-HasComments: No
[kudu-CR] Revert "[rest] add oat++ framework to kudu"
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has removed a vote on this change.
Change subject: Revert "[rest] add oat++ framework to kudu"
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/22040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie589074b67ed5ed23d4f83ccea8e3351caef5e7f
Gerrit-Change-Number: 22040
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] Revert "[rest] add oat++ framework to kudu"
Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/22040 )
Change subject: Revert "[rest] add oat++ framework to kudu"
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/22040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie589074b67ed5ed23d4f83ccea8e3351caef5e7f
Gerrit-Change-Number: 22040
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Dec 2024 10:09:39 +0000
Gerrit-HasComments: No
[kudu-CR] Revert "[rest] add oat++ framework to kudu"
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22040 )
Change subject: Revert "[rest] add oat++ framework to kudu"
......................................................................
Patch Set 1: -Verified
Build Started http://jenkins.kudu.apache.org/job/pre_commit/710/
--
To view, visit http://gerrit.cloudera.org:8080/22040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie589074b67ed5ed23d4f83ccea8e3351caef5e7f
Gerrit-Change-Number: 22040
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Nov 2024 11:44:37 +0000
Gerrit-HasComments: No