You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/02 21:07:08 UTC

[GitHub] [incubator-superset] john-bodley opened a new pull request #11143: chore: Remove obsolete creating missing metric permissions

john-bodley opened a new pull request #11143:
URL: https://github.com/apache/incubator-superset/pull/11143


   ### SUMMARY
   
   The "Creating missing metrics permissions" logic doesn't do anything with the set of metics, perviously per [here](https://github.com/apache/incubator-superset/blame/f510956da210e9edc24597b1cced27460eed07ac/superset/security.py#L207-L212) it did, though metric permissions were deprecated per [here](https://github.com/apache/incubator-superset/blob/9fc37ea9f1ff032dea923012613d4e7189ada178/superset/migrations/versions/11c737c17cc6_deprecate_restricted_metrics.py).
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   
   CI.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] john-bodley merged pull request #11143: chore: Remove obsolete creating missing metric permissions

Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #11143:
URL: https://github.com/apache/incubator-superset/pull/11143


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org