You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Joerg Schaible (JIRA)" <ji...@codehaus.org> on 2007/02/28 14:30:43 UTC

[jira] Created: (MRELEASE-201) Deployed POM is not valid XML

Deployed POM is not valid XML
-----------------------------

                 Key: MRELEASE-201
                 URL: http://jira.codehaus.org/browse/MRELEASE-201
             Project: Maven 2.x Release Plugin
          Issue Type: Bug
            Reporter: Joerg Schaible
         Attachments: MNG-2362.zip

If the POM has utf-8 encoding and you make usage of entities to support extended characters, these characters are no longer encoded as entities in the repository (well, the effect is already visible in target/effective-pom.xml). This is not a rule of general, POMs with packaging "pom" are installed and deployed correctly.

Multi module example. The attached archive contains a parent POM and a POM for a jar. Both UTF-8 encoded POMs contain a developer with a name using an entitiy. Releasing the POMs they are written with the expanded entitiy making the XML invalid.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MRELEASE-201) Deployed POM is not valid XML

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRELEASE-201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann closed MRELEASE-201.
--------------------------------------

         Assignee: Benjamin Bentmann
       Resolution: Fixed
    Fix Version/s: 2.0-beta-8

Fixed by MRELEASE-87. While the entities are still expanded by the Release Plugin, they are now properly encoded as given by the XML declaration (which is kept now).

> Deployed POM is not valid XML
> -----------------------------
>
>                 Key: MRELEASE-201
>                 URL: http://jira.codehaus.org/browse/MRELEASE-201
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>            Reporter: Joerg Schaible
>            Assignee: Benjamin Bentmann
>             Fix For: 2.0-beta-8
>
>         Attachments: MNG-2362.zip
>
>
> If the POM has utf-8 encoding and you make usage of entities to support extended characters, these characters are no longer encoded as entities in the repository (well, the effect is already visible in target/effective-pom.xml). This is not a rule of general, POMs with packaging "pom" are installed and deployed correctly.
> Multi module example. The attached archive contains a parent POM and a POM for a jar. Both UTF-8 encoded POMs contain a developer with a name using an entitiy. Releasing the POMs they are written with the expanded entitiy making the XML invalid.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRELEASE-201) Deployed POM is not valid XML

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRELEASE-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_116346 ] 

Benjamin Bentmann commented on MRELEASE-201:
--------------------------------------------

Another encoding problem: The plugin (2.0-beta-7) does not output an XML declaration in the rewritten POM. While this might be acceptable for UTF-8 encoded POMs (although I would consider it a betst practice to always output an XML declaration), it is in general wrong for any other encoding.

> Deployed POM is not valid XML
> -----------------------------
>
>                 Key: MRELEASE-201
>                 URL: http://jira.codehaus.org/browse/MRELEASE-201
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>            Reporter: Joerg Schaible
>         Attachments: MNG-2362.zip
>
>
> If the POM has utf-8 encoding and you make usage of entities to support extended characters, these characters are no longer encoded as entities in the repository (well, the effect is already visible in target/effective-pom.xml). This is not a rule of general, POMs with packaging "pom" are installed and deployed correctly.
> Multi module example. The attached archive contains a parent POM and a POM for a jar. Both UTF-8 encoded POMs contain a developer with a name using an entitiy. Releasing the POMs they are written with the expanded entitiy making the XML invalid.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRELEASE-201) Deployed POM is not valid XML

Posted by "Nathan Beyer (Cerner) (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRELEASE-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_116377 ] 

Nathan Beyer (Cerner) commented on MRELEASE-201:
------------------------------------------------

+1 for ALWAYS including an XML prolog that includes the encoding.

Since the POM file are often retrieve via HTTP, the lack of the encoding in the POM can be even more troublesome, as the encoding can be determined by the transport [1] if it's not in the XML prolog, so the "default" of UTF-8 doesn't always apply. This means that the encoding maybe determined by default content-type values set in the web server's configuration. This adds a significant amount of variability, which would be eliminated by explicitly setting the encoding in the prolog.

[1] http://www.w3.org/TR/2006/REC-xml-20060816/#sec-prolog-dtd

> Deployed POM is not valid XML
> -----------------------------
>
>                 Key: MRELEASE-201
>                 URL: http://jira.codehaus.org/browse/MRELEASE-201
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>            Reporter: Joerg Schaible
>         Attachments: MNG-2362.zip
>
>
> If the POM has utf-8 encoding and you make usage of entities to support extended characters, these characters are no longer encoded as entities in the repository (well, the effect is already visible in target/effective-pom.xml). This is not a rule of general, POMs with packaging "pom" are installed and deployed correctly.
> Multi module example. The attached archive contains a parent POM and a POM for a jar. Both UTF-8 encoded POMs contain a developer with a name using an entitiy. Releasing the POMs they are written with the expanded entitiy making the XML invalid.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira