You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2016/08/19 22:11:32 UTC
[GitHub] flink pull request #2395: [FLINK-4355] [cluster management] Add tests for th...
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/2395
[FLINK-4355] [cluster management] Add tests for the TaskManager -> ResourceManager registration.
This adds the missing tests for [FLINK-4355].
It makes use of the testing RPC service suggested in #2394 - only the second commit () is hence relevant for this pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink task_executor_tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2395.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2395
----
commit a685ffa00d748de4ab22f91b1dc3b6420f687c24
Author: Stephan Ewen <se...@apache.org>
Date: 2016-08-19T21:29:45Z
[FLINK-4434] [rpc] Add a testing RPC service.
commit c72b2cb34521e35a4ad949c4384eb94afd0ff99c
Author: Stephan Ewen <se...@apache.org>
Date: 2016-08-19T21:45:54Z
[FLINK-4355] [cluster management] Add tests for the TaskManager -> ResourceManager registration.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2395: [FLINK-4355] [cluster management] Add tests for th...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen closed the pull request at:
https://github.com/apache/flink/pull/2395
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2395: [FLINK-4355] [cluster management] Add tests for the TaskM...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2395
Nice test cases @StephanEwen. The test cases look really succinct without much overhead with the new RPC abstraction. I like that a lot :-)
The PR currently fails because of a compilation problem. I'll fix it and if Travis gives green light, then I'll merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2395: [FLINK-4355] [cluster management] Add tests for the TaskM...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2395
Manually merged to the `flip-6` branch in be80f400fbe24389a8d7a1fa9159f6bd80e3a2d9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---