You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/11/29 17:40:27 UTC
Re: Review Request 64142: Updated master ACCEPT handler to disallow
offer operation feedback.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64142/
-----------------------------------------------------------
(Updated Nov. 29, 2017, 5:40 p.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
Summary (updated)
-----------------
Updated master ACCEPT handler to disallow offer operation feedback.
Bugs: MESOS-8193
https://issues.apache.org/jira/browse/MESOS-8193
Repository: mesos
Description (updated)
-------
This patch updates the master's ACCEPT call code path to fail
offer operations when their `id` field is set. Since protobufs
have already been updated for offer operation feedback, but the
feature is not fully implemented, we will disallow the setting
of this field for now.
Diffs
-----
src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144
Diff: https://reviews.apache.org/r/64142/diff/1/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 64142: Updated master ACCEPT handler to disallow
offer operation feedback.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64142/#review192950
-----------------------------------------------------------
Ship it!
Ship It!
- Gaston Kleiman
On Dec. 4, 2017, 2:08 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64142/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2017, 2:08 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8054
> https://issues.apache.org/jira/browse/MESOS-8054
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the master's ACCEPT call code path to fail
> offer operations when their `id` field is set. Since protobufs
> have already been updated for offer operation feedback, but the
> feature is not fully implemented, we will disallow the setting
> of this field for now.
>
>
> Diffs
> -----
>
> src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4
>
>
> Diff: https://reviews.apache.org/r/64142/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 64142: Updated master ACCEPT handler to disallow
offer operation feedback.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64142/
-----------------------------------------------------------
(Updated Dec. 4, 2017, 10:08 p.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
Bugs: MESOS-8054
https://issues.apache.org/jira/browse/MESOS-8054
Repository: mesos
Description
-------
This patch updates the master's ACCEPT call code path to fail
offer operations when their `id` field is set. Since protobufs
have already been updated for offer operation feedback, but the
feature is not fully implemented, we will disallow the setting
of this field for now.
Diffs (updated)
-----
src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4
Diff: https://reviews.apache.org/r/64142/diff/2/
Changes: https://reviews.apache.org/r/64142/diff/1-2/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 64142: Updated master ACCEPT handler to disallow
offer operation feedback.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64142/#review192355
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp
Lines 4139-4143 (patched)
<https://reviews.apache.org/r/64142/#comment270456>
Can you move this inside the `else if` block below?
- Jie Yu
On Nov. 29, 2017, 5:42 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64142/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 5:42 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8054
> https://issues.apache.org/jira/browse/MESOS-8054
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the master's ACCEPT call code path to fail
> offer operations when their `id` field is set. Since protobufs
> have already been updated for offer operation feedback, but the
> feature is not fully implemented, we will disallow the setting
> of this field for now.
>
>
> Diffs
> -----
>
> src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144
>
>
> Diff: https://reviews.apache.org/r/64142/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 64142: Updated master ACCEPT handler to disallow
offer operation feedback.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64142/
-----------------------------------------------------------
(Updated Nov. 29, 2017, 5:42 p.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
Bugs: MESOS-8054
https://issues.apache.org/jira/browse/MESOS-8054
Repository: mesos
Description
-------
This patch updates the master's ACCEPT call code path to fail
offer operations when their `id` field is set. Since protobufs
have already been updated for offer operation feedback, but the
feature is not fully implemented, we will disallow the setting
of this field for now.
Diffs
-----
src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144
Diff: https://reviews.apache.org/r/64142/diff/1/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 64142: Updated master ACCEPT handler to disallow
offer operation feedback.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64142/
-----------------------------------------------------------
(Updated Nov. 29, 2017, 5:42 p.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
Repository: mesos
Description
-------
This patch updates the master's ACCEPT call code path to fail
offer operations when their `id` field is set. Since protobufs
have already been updated for offer operation feedback, but the
feature is not fully implemented, we will disallow the setting
of this field for now.
Diffs
-----
src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144
Diff: https://reviews.apache.org/r/64142/diff/1/
Testing
-------
make check
Thanks,
Greg Mann