You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/03/12 23:11:40 UTC
Review Request 19159: Add killall.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: aurora-260
https://issues.apache.org/jira/browse/aurora-260
Repository: aurora
Description
-------
Add killall.
- the kill command now requires a shards parameter.
- the new killall command only works when run with "--force".
- killall generates a scary warning message, and pauses to give
the user a chance to abort.
Diffs
-----
src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
Diff: https://reviews.apache.org/r/19159/diff/
Testing
-------
Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
[sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
============================= test session starts =============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 26 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py .....
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ..
src/test/python/apache/aurora/client/commands/test_update.py ...
========================= 26 passed in 11.34 seconds ==========================
src.test.python.apache.aurora.client.commands.core ..... SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 19159: Add killall.
Posted by Kevin Sweeney <ke...@apache.org>.
> On March 12, 2014, 3:25 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/commands/core.py, line 399
> > <https://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line399>
> >
> > This is deliberate: the "kill" command doesn't have a "force" option. So this ensures that there's more than a search-and-replace killall for kill: you need to deliberately use the killall command, and specify the force option.
> >
> > The require --shards is also in this change - see the change above in kill.
>
> Maxim Khutornenko wrote:
> Missed the --shards part, thanks.
>
>
> Kevin Sweeney wrote:
> If someone is going to search-and-replace kill with killall without wanting to do that I'm not sure we can stop them from shooting themselves in the foot. Up to you but I'm in favor of dropping this required option.
>
> Kevin Sweeney wrote:
> I run unqualified kill (which will now be killall) all the time when iterating on development jobs - the only time it's extraordinary/highly unrecommended is when the target is a production service.
Which is to say I run it when I specifically *don't* want the rolling updates behavior but rather just want to kill and create as quickly as the scheduler can do it. Obviously this is a very bad idea for production services but the aurora command can interact with more than just production services. I like the killall change because it saves you from accidentally doing it implicitly when you forgot a backslash before a newline, e.g.
aurora kill smf1/aurora/prod/some_service
--shards=0
instead of
aurora kill smf1/aurora/prod/some_service \
--shards=0
For the case where you're using killall you don't have the risk of this.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/#review37008
-----------------------------------------------------------
On March 12, 2014, 3:11 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19159/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 3:11 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: aurora-260
> https://issues.apache.org/jira/browse/aurora-260
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add killall.
>
> - the kill command now requires a shards parameter.
> - the new killall command only works when run with "--force".
> - killall generates a scary warning message, and pauses to give
> the user a chance to abort.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
> src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
>
> Diff: https://reviews.apache.org/r/19159/diff/
>
>
> Testing
> -------
>
> Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
>
> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
> ============================= test session starts =============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py .....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================= 26 passed in 11.34 seconds ==========================
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19159: Add killall.
Posted by Mark Chu-Carroll <mc...@apache.org>.
But in some sense, this isn't a standard command. This is a dangerous
command, and we want it to be out of the ordinary. We want to be sure that
it's not done accidentally, and making its flag behavior be strange is
arguably good.
-Mark
On Thu, Mar 13, 2014 at 11:14 AM, Maxim Khutornenko <ma...@apache.org>wrote:
> What looks odd though is a command that is unusable without the --force
> flag. The standard optional semantic of that flag feels violated here.
>
>
> On Thu, Mar 13, 2014 at 11:10 AM, Maxim Khutornenko <ma...@apache.org>wrote:
>
>> What looks odd though is a command that is unusable without the --force
>> flag. The standard optional semantic of that flag is violated here.
>>
>> On Mar 13, 2014, at 11:07 AM, Mark Chu-Carroll <mc...@apache.org>
>> wrote:
>>
>> I think making a reasonable effort to make it harder to accidentally do
>> this is worthwhile - there's no harm in it, and it might just help.
>>
>> -Mark
>>
>>
>> On Thu, Mar 13, 2014 at 10:07 AM, Kevin Sweeney <ke...@apache.org>wrote:
>>
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/19159/
>>>
>>> On March 12th, 2014, 3:25 p.m. PDT, *Mark Chu-Carroll* wrote:
>>>
>>> src/main/python/apache/aurora/client/commands/core.py<https://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line399> (Diff
>>> revision 1)
>>>
>>> def show_job_pretty(job):
>>>
>>> 397
>>>
>>> @app.command_option('--force', default=False, action='store_true',
>>>
>>> This is deliberate: the "kill" command doesn't have a "force" option. So this ensures that there's more than a search-and-replace killall for kill: you need to deliberately use the killall command, and specify the force option.
>>>
>>> The require --shards is also in this change - see the change above in kill.
>>>
>>> On March 12th, 2014, 3:29 p.m. PDT, *Maxim Khutornenko* wrote:
>>>
>>> Missed the --shards part, thanks.
>>>
>>> If someone is going to search-and-replace kill with killall without wanting to do that I'm not sure we can stop them from shooting themselves in the foot. Up to you but I'm in favor of dropping this required option.
>>>
>>>
>>> - Kevin
>>>
>>> On March 12th, 2014, 3:11 p.m. PDT, Mark Chu-Carroll wrote:
>>> Review request for Aurora, Kevin Sweeney and Bill Farner.
>>> By Mark Chu-Carroll.
>>>
>>> *Updated March 12, 2014, 3:11 p.m.*
>>> *Bugs: * aurora-260 <https://issues.apache.org/jira/browse/aurora-260>
>>> *Repository: * aurora
>>> Description
>>>
>>> Add killall.
>>>
>>> - the kill command now requires a shards parameter.
>>> - the new killall command only works when run with "--force".
>>> - killall generates a scary warning message, and pauses to give
>>> the user a chance to abort.
>>>
>>> Testing
>>>
>>> Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
>>>
>>> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
>>> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
>>> ============================= test session starts =============================
>>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>>> collected 26 items
>>>
>>> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
>>> src/test/python/apache/aurora/client/commands/test_create.py ......
>>> src/test/python/apache/aurora/client/commands/test_diff.py ...
>>> src/test/python/apache/aurora/client/commands/test_kill.py .....
>>> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
>>> src/test/python/apache/aurora/client/commands/test_restart.py ...
>>> src/test/python/apache/aurora/client/commands/test_status.py ..
>>> src/test/python/apache/aurora/client/commands/test_update.py ...
>>>
>>> ========================= 26 passed in 11.34 seconds ==========================
>>> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
>>>
>>> Diffs
>>>
>>> - src/main/python/apache/aurora/client/commands/core.py
>>> (ff0f1f8668c8c405fa3a41b70cae32004034e223)
>>> - src/test/python/apache/aurora/client/commands/test_kill.py
>>> (7639dc98bfea0663461d15e3d46f1aedd13b124f)
>>>
>>> View Diff <https://reviews.apache.org/r/19159/diff/>
>>>
>>
>>
>>
>
Re: Review Request 19159: Add killall.
Posted by Maxim Khutornenko <ma...@apache.org>.
What looks odd though is a command that is unusable without the --force
flag. The standard optional semantic of that flag feels violated here.
On Thu, Mar 13, 2014 at 11:10 AM, Maxim Khutornenko <ma...@apache.org>wrote:
> What looks odd though is a command that is unusable without the --force
> flag. The standard optional semantic of that flag is violated here.
>
> On Mar 13, 2014, at 11:07 AM, Mark Chu-Carroll <mc...@apache.org>
> wrote:
>
> I think making a reasonable effort to make it harder to accidentally do
> this is worthwhile - there's no harm in it, and it might just help.
>
> -Mark
>
>
> On Thu, Mar 13, 2014 at 10:07 AM, Kevin Sweeney <ke...@apache.org>wrote:
>
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/19159/
>>
>> On March 12th, 2014, 3:25 p.m. PDT, *Mark Chu-Carroll* wrote:
>>
>> src/main/python/apache/aurora/client/commands/core.py<https://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line399> (Diff
>> revision 1)
>>
>> def show_job_pretty(job):
>>
>> 397
>>
>> @app.command_option('--force', default=False, action='store_true',
>>
>> This is deliberate: the "kill" command doesn't have a "force" option. So this ensures that there's more than a search-and-replace killall for kill: you need to deliberately use the killall command, and specify the force option.
>>
>> The require --shards is also in this change - see the change above in kill.
>>
>> On March 12th, 2014, 3:29 p.m. PDT, *Maxim Khutornenko* wrote:
>>
>> Missed the --shards part, thanks.
>>
>> If someone is going to search-and-replace kill with killall without wanting to do that I'm not sure we can stop them from shooting themselves in the foot. Up to you but I'm in favor of dropping this required option.
>>
>>
>> - Kevin
>>
>> On March 12th, 2014, 3:11 p.m. PDT, Mark Chu-Carroll wrote:
>> Review request for Aurora, Kevin Sweeney and Bill Farner.
>> By Mark Chu-Carroll.
>>
>> *Updated March 12, 2014, 3:11 p.m.*
>> *Bugs: * aurora-260 <https://issues.apache.org/jira/browse/aurora-260>
>> *Repository: * aurora
>> Description
>>
>> Add killall.
>>
>> - the kill command now requires a shards parameter.
>> - the new killall command only works when run with "--force".
>> - killall generates a scary warning message, and pauses to give
>> the user a chance to abort.
>>
>> Testing
>>
>> Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
>>
>> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
>> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
>> ============================= test session starts =============================
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 26 items
>>
>> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
>> src/test/python/apache/aurora/client/commands/test_create.py ......
>> src/test/python/apache/aurora/client/commands/test_diff.py ...
>> src/test/python/apache/aurora/client/commands/test_kill.py .....
>> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
>> src/test/python/apache/aurora/client/commands/test_restart.py ...
>> src/test/python/apache/aurora/client/commands/test_status.py ..
>> src/test/python/apache/aurora/client/commands/test_update.py ...
>>
>> ========================= 26 passed in 11.34 seconds ==========================
>> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
>>
>> Diffs
>>
>> - src/main/python/apache/aurora/client/commands/core.py
>> (ff0f1f8668c8c405fa3a41b70cae32004034e223)
>> - src/test/python/apache/aurora/client/commands/test_kill.py
>> (7639dc98bfea0663461d15e3d46f1aedd13b124f)
>>
>> View Diff <https://reviews.apache.org/r/19159/diff/>
>>
>
>
>
Re: Review Request 19159: Add killall.
Posted by Mark Chu-Carroll <mc...@apache.org>.
I think making a reasonable effort to make it harder to accidentally do
this is worthwhile - there's no harm in it, and it might just help.
-Mark
On Thu, Mar 13, 2014 at 10:07 AM, Kevin Sweeney <ke...@apache.org> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19159/
>
> On March 12th, 2014, 3:25 p.m. PDT, *Mark Chu-Carroll* wrote:
>
> src/main/python/apache/aurora/client/commands/core.py<https://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line399> (Diff
> revision 1)
>
> def show_job_pretty(job):
>
> 397
>
> @app.command_option('--force', default=False, action='store_true',
>
> This is deliberate: the "kill" command doesn't have a "force" option. So this ensures that there's more than a search-and-replace killall for kill: you need to deliberately use the killall command, and specify the force option.
>
> The require --shards is also in this change - see the change above in kill.
>
> On March 12th, 2014, 3:29 p.m. PDT, *Maxim Khutornenko* wrote:
>
> Missed the --shards part, thanks.
>
> If someone is going to search-and-replace kill with killall without wanting to do that I'm not sure we can stop them from shooting themselves in the foot. Up to you but I'm in favor of dropping this required option.
>
>
> - Kevin
>
> On March 12th, 2014, 3:11 p.m. PDT, Mark Chu-Carroll wrote:
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> By Mark Chu-Carroll.
>
> *Updated March 12, 2014, 3:11 p.m.*
> *Bugs: * aurora-260 <https://issues.apache.org/jira/browse/aurora-260>
> *Repository: * aurora
> Description
>
> Add killall.
>
> - the kill command now requires a shards parameter.
> - the new killall command only works when run with "--force".
> - killall generates a scary warning message, and pauses to give
> the user a chance to abort.
>
> Testing
>
> Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
>
> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
> ============================= test session starts =============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py .....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================= 26 passed in 11.34 seconds ==========================
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
>
> Diffs
>
> - src/main/python/apache/aurora/client/commands/core.py
> (ff0f1f8668c8c405fa3a41b70cae32004034e223)
> - src/test/python/apache/aurora/client/commands/test_kill.py
> (7639dc98bfea0663461d15e3d46f1aedd13b124f)
>
> View Diff <https://reviews.apache.org/r/19159/diff/>
>
Re: Review Request 19159: Add killall.
Posted by Kevin Sweeney <ke...@apache.org>.
> On March 12, 2014, 3:25 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/commands/core.py, line 399
> > <https://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line399>
> >
> > This is deliberate: the "kill" command doesn't have a "force" option. So this ensures that there's more than a search-and-replace killall for kill: you need to deliberately use the killall command, and specify the force option.
> >
> > The require --shards is also in this change - see the change above in kill.
>
> Maxim Khutornenko wrote:
> Missed the --shards part, thanks.
>
If someone is going to search-and-replace kill with killall without wanting to do that I'm not sure we can stop them from shooting themselves in the foot. Up to you but I'm in favor of dropping this required option.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/#review37008
-----------------------------------------------------------
On March 12, 2014, 3:11 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19159/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 3:11 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: aurora-260
> https://issues.apache.org/jira/browse/aurora-260
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add killall.
>
> - the kill command now requires a shards parameter.
> - the new killall command only works when run with "--force".
> - killall generates a scary warning message, and pauses to give
> the user a chance to abort.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
> src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
>
> Diff: https://reviews.apache.org/r/19159/diff/
>
>
> Testing
> -------
>
> Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
>
> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
> ============================= test session starts =============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py .....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================= 26 passed in 11.34 seconds ==========================
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19159: Add killall.
Posted by Kevin Sweeney <ke...@apache.org>.
> On March 12, 2014, 3:25 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/commands/core.py, line 399
> > <https://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line399>
> >
> > This is deliberate: the "kill" command doesn't have a "force" option. So this ensures that there's more than a search-and-replace killall for kill: you need to deliberately use the killall command, and specify the force option.
> >
> > The require --shards is also in this change - see the change above in kill.
>
> Maxim Khutornenko wrote:
> Missed the --shards part, thanks.
>
>
> Kevin Sweeney wrote:
> If someone is going to search-and-replace kill with killall without wanting to do that I'm not sure we can stop them from shooting themselves in the foot. Up to you but I'm in favor of dropping this required option.
I run unqualified kill (which will now be killall) all the time when iterating on development jobs - the only time it's extraordinary/highly unrecommended is when the target is a production service.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/#review37008
-----------------------------------------------------------
On March 12, 2014, 3:11 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19159/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 3:11 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: aurora-260
> https://issues.apache.org/jira/browse/aurora-260
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add killall.
>
> - the kill command now requires a shards parameter.
> - the new killall command only works when run with "--force".
> - killall generates a scary warning message, and pauses to give
> the user a chance to abort.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
> src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
>
> Diff: https://reviews.apache.org/r/19159/diff/
>
>
> Testing
> -------
>
> Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
>
> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
> ============================= test session starts =============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py .....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================= 26 passed in 11.34 seconds ==========================
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19159: Add killall.
Posted by Mark Chu-Carroll <mc...@apache.org>.
Bill, Kevin:
Can you please try to take a quick look at this? I'd really like to get it
in to Maxim's deploy this morning.
-Mark
On Wed, Mar 12, 2014 at 3:29 PM, Maxim Khutornenko <ma...@apache.org> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19159/
>
> On March 12th, 2014, 10:25 p.m. UTC, *Mark Chu-Carroll* wrote:
>
> src/main/python/apache/aurora/client/commands/core.py<https://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line399> (Diff
> revision 1)
>
> def show_job_pretty(job):
>
> 397
>
> @app.command_option('--force', default=False, action='store_true',
>
> This is deliberate: the "kill" command doesn't have a "force" option. So this ensures that there's more than a search-and-replace killall for kill: you need to deliberately use the killall command, and specify the force option.
>
> The require --shards is also in this change - see the change above in kill.
>
> Missed the --shards part, thanks.
>
>
> - Maxim
>
> On March 12th, 2014, 10:11 p.m. UTC, Mark Chu-Carroll wrote:
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> By Mark Chu-Carroll.
>
> *Updated March 12, 2014, 10:11 p.m.*
> *Bugs: * aurora-260 <https://issues.apache.org/jira/browse/aurora-260>
> *Repository: * aurora
> Description
>
> Add killall.
>
> - the kill command now requires a shards parameter.
> - the new killall command only works when run with "--force".
> - killall generates a scary warning message, and pauses to give
> the user a chance to abort.
>
> Testing
>
> Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
>
> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
> ============================= test session starts =============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py .....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================= 26 passed in 11.34 seconds ==========================
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
>
> Diffs
>
> - src/main/python/apache/aurora/client/commands/core.py
> (ff0f1f8668c8c405fa3a41b70cae32004034e223)
> - src/test/python/apache/aurora/client/commands/test_kill.py
> (7639dc98bfea0663461d15e3d46f1aedd13b124f)
>
> View Diff <https://reviews.apache.org/r/19159/diff/>
>
Re: Review Request 19159: Add killall.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On March 12, 2014, 10:25 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/commands/core.py, line 399
> > <https://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line399>
> >
> > This is deliberate: the "kill" command doesn't have a "force" option. So this ensures that there's more than a search-and-replace killall for kill: you need to deliberately use the killall command, and specify the force option.
> >
> > The require --shards is also in this change - see the change above in kill.
Missed the --shards part, thanks.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/#review37008
-----------------------------------------------------------
On March 12, 2014, 10:11 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19159/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 10:11 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: aurora-260
> https://issues.apache.org/jira/browse/aurora-260
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add killall.
>
> - the kill command now requires a shards parameter.
> - the new killall command only works when run with "--force".
> - killall generates a scary warning message, and pauses to give
> the user a chance to abort.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
> src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
>
> Diff: https://reviews.apache.org/r/19159/diff/
>
>
> Testing
> -------
>
> Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
>
> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
> ============================= test session starts =============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py .....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================= 26 passed in 11.34 seconds ==========================
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19159: Add killall.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/#review37008
-----------------------------------------------------------
src/main/python/apache/aurora/client/commands/core.py
<https://reviews.apache.org/r/19159/#comment68255>
This is deliberate: the "kill" command doesn't have a "force" option. So this ensures that there's more than a search-and-replace killall for kill: you need to deliberately use the killall command, and specify the force option.
The require --shards is also in this change - see the change above in kill.
- Mark Chu-Carroll
On March 12, 2014, 6:11 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19159/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 6:11 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: aurora-260
> https://issues.apache.org/jira/browse/aurora-260
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add killall.
>
> - the kill command now requires a shards parameter.
> - the new killall command only works when run with "--force".
> - killall generates a scary warning message, and pauses to give
> the user a chance to abort.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
> src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
>
> Diff: https://reviews.apache.org/r/19159/diff/
>
>
> Testing
> -------
>
> Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
>
> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
> ============================= test session starts =============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py .....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================= 26 passed in 11.34 seconds ==========================
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19159: Add killall.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/#review37153
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On March 14, 2014, 12:14 a.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19159/
> -----------------------------------------------------------
>
> (Updated March 14, 2014, 12:14 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: aurora-260
> https://issues.apache.org/jira/browse/aurora-260
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add killall.
>
> - the kill command now requires a shards parameter.
> - the new killall command only works when run with "--force".
> - killall generates a scary warning message, and pauses to give
> the user a chance to abort.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
> src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 00a80d90c2ce9b6134784a91c2cb9d9e966446ae
>
> Diff: https://reviews.apache.org/r/19159/diff/
>
>
> Testing
> -------
>
> Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
>
> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
> ============================= test session starts =============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py .....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================= 26 passed in 11.34 seconds ==========================
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19159: Add killall.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/
-----------------------------------------------------------
(Updated March 17, 2014, 3:45 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Fix glitch introduced in tests by earlier review change.
Bugs: aurora-260
https://issues.apache.org/jira/browse/aurora-260
Repository: aurora
Description
-------
Add killall.
- the kill command now requires a shards parameter.
- the new killall command only works when run with "--force".
- killall generates a scary warning message, and pauses to give
the user a chance to abort.
Diffs (updated)
-----
src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 00a80d90c2ce9b6134784a91c2cb9d9e966446ae
Diff: https://reviews.apache.org/r/19159/diff/
Testing
-------
Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
[sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
============================= test session starts =============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 26 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py .....
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ..
src/test/python/apache/aurora/client/commands/test_update.py ...
========================= 26 passed in 11.34 seconds ==========================
src.test.python.apache.aurora.client.commands.core ..... SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 19159: Add killall.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/
-----------------------------------------------------------
(Updated March 17, 2014, 3:02 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Rebase to master.
Bugs: aurora-260
https://issues.apache.org/jira/browse/aurora-260
Repository: aurora
Description
-------
Add killall.
- the kill command now requires a shards parameter.
- the new killall command only works when run with "--force".
- killall generates a scary warning message, and pauses to give
the user a chance to abort.
Diffs (updated)
-----
src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 00a80d90c2ce9b6134784a91c2cb9d9e966446ae
Diff: https://reviews.apache.org/r/19159/diff/
Testing
-------
Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
[sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
============================= test session starts =============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 26 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py .....
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ..
src/test/python/apache/aurora/client/commands/test_update.py ...
========================= 26 passed in 11.34 seconds ==========================
src.test.python.apache.aurora.client.commands.core ..... SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 19159: Add killall.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/#review37141
-----------------------------------------------------------
Ship it!
src/main/python/apache/aurora/client/commands/core.py
<https://reviews.apache.org/r/19159/#comment68515>
Not needed since we're no longer disambiguating the old --cluster=a ROLE NAME form.
- Kevin Sweeney
On March 13, 2014, 5:14 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19159/
> -----------------------------------------------------------
>
> (Updated March 13, 2014, 5:14 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: aurora-260
> https://issues.apache.org/jira/browse/aurora-260
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add killall.
>
> - the kill command now requires a shards parameter.
> - the new killall command only works when run with "--force".
> - killall generates a scary warning message, and pauses to give
> the user a chance to abort.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
> src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 00a80d90c2ce9b6134784a91c2cb9d9e966446ae
>
> Diff: https://reviews.apache.org/r/19159/diff/
>
>
> Testing
> -------
>
> Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
>
> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
> ============================= test session starts =============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py .....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================= 26 passed in 11.34 seconds ==========================
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19159: Add killall.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/
-----------------------------------------------------------
(Updated March 13, 2014, 8:14 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: aurora-260
https://issues.apache.org/jira/browse/aurora-260
Repository: aurora
Description
-------
Add killall.
- the kill command now requires a shards parameter.
- the new killall command only works when run with "--force".
- killall generates a scary warning message, and pauses to give
the user a chance to abort.
Diffs
-----
src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 00a80d90c2ce9b6134784a91c2cb9d9e966446ae
Diff: https://reviews.apache.org/r/19159/diff/
Testing
-------
Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
[sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
============================= test session starts =============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 26 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py .....
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ..
src/test/python/apache/aurora/client/commands/test_update.py ...
========================= 26 passed in 11.34 seconds ==========================
src.test.python.apache.aurora.client.commands.core ..... SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 19159: Add killall.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/
-----------------------------------------------------------
(Updated March 13, 2014, 8:14 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Get rid of the use of the disambiguator in the new killall command.
Fix the end-to-end test.
Bugs: aurora-260
https://issues.apache.org/jira/browse/aurora-260
Repository: aurora
Description
-------
Add killall.
- the kill command now requires a shards parameter.
- the new killall command only works when run with "--force".
- killall generates a scary warning message, and pauses to give
the user a chance to abort.
Diffs (updated)
-----
src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 00a80d90c2ce9b6134784a91c2cb9d9e966446ae
Diff: https://reviews.apache.org/r/19159/diff/
Testing
-------
Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
[sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
============================= test session starts =============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 26 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py .....
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ..
src/test/python/apache/aurora/client/commands/test_update.py ...
========================= 26 passed in 11.34 seconds ==========================
src.test.python.apache.aurora.client.commands.core ..... SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 19159: Add killall.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/#review37139
-----------------------------------------------------------
Have you updated the end-to-end test?
src/main/python/apache/aurora/client/commands/core.py
<https://reviews.apache.org/r/19159/#comment68506>
Since this is a new command, there's no need to maintain backwards compatibility via LiveJobDisambiguator.
- Kevin Sweeney
On March 13, 2014, 4:59 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19159/
> -----------------------------------------------------------
>
> (Updated March 13, 2014, 4:59 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: aurora-260
> https://issues.apache.org/jira/browse/aurora-260
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add killall.
>
> - the kill command now requires a shards parameter.
> - the new killall command only works when run with "--force".
> - killall generates a scary warning message, and pauses to give
> the user a chance to abort.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
> src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
>
> Diff: https://reviews.apache.org/r/19159/diff/
>
>
> Testing
> -------
>
> Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
>
> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
> ============================= test session starts =============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py .....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================= 26 passed in 11.34 seconds ==========================
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19159: Add killall.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/
-----------------------------------------------------------
(Updated March 13, 2014, 7:59 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Get rid of prompt/delay on killall.
Bugs: aurora-260
https://issues.apache.org/jira/browse/aurora-260
Repository: aurora
Description
-------
Add killall.
- the kill command now requires a shards parameter.
- the new killall command only works when run with "--force".
- killall generates a scary warning message, and pauses to give
the user a chance to abort.
Diffs (updated)
-----
src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
Diff: https://reviews.apache.org/r/19159/diff/
Testing
-------
Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
[sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
============================= test session starts =============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 26 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py .....
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ..
src/test/python/apache/aurora/client/commands/test_update.py ...
========================= 26 passed in 11.34 seconds ==========================
src.test.python.apache.aurora.client.commands.core ..... SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 19159: Add killall.
Posted by Bill Farner <wf...@apache.org>.
> On March 13, 2014, 9:56 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/client/commands/core.py, lines 413-415
> > <https://reviews.apache.org/r/19159/diff/2/?file=518936#file518936line413>
> >
> > I'm not a fan of embedding this sleep behavior either - this can be accomplished with hooks. For my use case of quick iteration this adds slowness for no apparent reason.
Let's proceed without the warning and sleep for now, we can discuss the policy end of things more offline.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/#review37067
-----------------------------------------------------------
On March 13, 2014, 8:05 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19159/
> -----------------------------------------------------------
>
> (Updated March 13, 2014, 8:05 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: aurora-260
> https://issues.apache.org/jira/browse/aurora-260
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add killall.
>
> - the kill command now requires a shards parameter.
> - the new killall command only works when run with "--force".
> - killall generates a scary warning message, and pauses to give
> the user a chance to abort.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
> src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
>
> Diff: https://reviews.apache.org/r/19159/diff/
>
>
> Testing
> -------
>
> Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
>
> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
> ============================= test session starts =============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py .....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================= 26 passed in 11.34 seconds ==========================
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19159: Add killall.
Posted by Mark Chu-Carroll <mc...@apache.org>.
Bill, Chris, and I discussed this yesterday, and the consensus was that a
warning message, followed by a pause to give an opportunity to cancel was
the best option. I'd rather not re-argue the issue yet another time!
-Mark
On Thu, Mar 13, 2014 at 2:56 PM, Kevin Sweeney <ke...@apache.org> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19159/
> src/main/python/apache/aurora/client/commands/core.py<https://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line386> (Diff
> revision 1)
>
> def show_job_pretty(job):
>
> 384
>
> print('Shards option is required for kill; use killall to kill all shards')
>
> file=sys.stderr?
>
>
> src/main/python/apache/aurora/client/commands/core.py<https://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line406> (Diff
> revision 1)
>
> 404
>
> if not options.force:
>
> 405
>
> print('killall requires the force option to indicate that you really want to kill the job.')
>
> 406
>
> exit(1)
>
> In favor of dropping this, but if you don't this should be file=sys.stderr.
>
>
> src/main/python/apache/aurora/client/commands/core.py<https://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line413> (Diff
> revision 1)
>
> 411
>
> print('**** Warning! This is going to kill all tasks in this job!')
>
> 412
>
> print('**** Tasks will be killed in 10 seconds. Press ^C to abort!')
>
> stderr
>
>
> src/main/python/apache/aurora/client/commands/core.py<https://reviews.apache.org/r/19159/diff/2/?file=518936#file518936line413> (Diff
> revision 2)
>
> 411
>
> print('**** Warning! This is going to kill all tasks in this job!')
>
> 412
>
> print('**** Tasks will be killed in 10 seconds. Press ^C to abort!')
>
> 413
>
> time.sleep(10)
>
> I'm not a fan of embedding this sleep behavior either - this can be accomplished with hooks. For my use case of quick iteration this adds slowness for no apparent reason.
>
>
> src/main/python/apache/aurora/client/commands/core.py<https://reviews.apache.org/r/19159/diff/2/?file=518936#file518936line415> (Diff
> revision 2)
>
> 413
>
> time.sleep(10)
>
> You use this value in your test - can you extract a constant?
>
>
> - Kevin Sweeney
>
> On March 13th, 2014, 1:05 p.m. PDT, Mark Chu-Carroll wrote:
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> By Mark Chu-Carroll.
>
> *Updated March 13, 2014, 1:05 p.m.*
> *Bugs: * aurora-260 <https://issues.apache.org/jira/browse/aurora-260>
> *Repository: * aurora
> Description
>
> Add killall.
>
> - the kill command now requires a shards parameter.
> - the new killall command only works when run with "--force".
> - killall generates a scary warning message, and pauses to give
> the user a chance to abort.
>
> Testing
>
> Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
>
> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
> ============================= test session starts =============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py .....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================= 26 passed in 11.34 seconds ==========================
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
>
> Diffs
>
> - src/main/python/apache/aurora/client/commands/core.py
> (ff0f1f8668c8c405fa3a41b70cae32004034e223)
> - src/test/python/apache/aurora/client/commands/test_kill.py
> (7639dc98bfea0663461d15e3d46f1aedd13b124f)
>
> View Diff <https://reviews.apache.org/r/19159/diff/>
>
Re: Review Request 19159: Add killall.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/#review37067
-----------------------------------------------------------
src/main/python/apache/aurora/client/commands/core.py
<https://reviews.apache.org/r/19159/#comment68326>
file=sys.stderr?
src/main/python/apache/aurora/client/commands/core.py
<https://reviews.apache.org/r/19159/#comment68328>
In favor of dropping this, but if you don't this should be file=sys.stderr.
src/main/python/apache/aurora/client/commands/core.py
<https://reviews.apache.org/r/19159/#comment68329>
stderr
src/main/python/apache/aurora/client/commands/core.py
<https://reviews.apache.org/r/19159/#comment68454>
I'm not a fan of embedding this sleep behavior either - this can be accomplished with hooks. For my use case of quick iteration this adds slowness for no apparent reason.
src/main/python/apache/aurora/client/commands/core.py
<https://reviews.apache.org/r/19159/#comment68452>
You use this value in your test - can you extract a constant?
- Kevin Sweeney
On March 13, 2014, 1:05 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19159/
> -----------------------------------------------------------
>
> (Updated March 13, 2014, 1:05 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: aurora-260
> https://issues.apache.org/jira/browse/aurora-260
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add killall.
>
> - the kill command now requires a shards parameter.
> - the new killall command only works when run with "--force".
> - killall generates a scary warning message, and pauses to give
> the user a chance to abort.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
> src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
>
> Diff: https://reviews.apache.org/r/19159/diff/
>
>
> Testing
> -------
>
> Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
>
> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
> ============================= test session starts =============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py .....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================= 26 passed in 11.34 seconds ==========================
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19159: Add killall.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/
-----------------------------------------------------------
(Updated March 13, 2014, 4:05 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
address maxim's review.
Bugs: aurora-260
https://issues.apache.org/jira/browse/aurora-260
Repository: aurora
Description
-------
Add killall.
- the kill command now requires a shards parameter.
- the new killall command only works when run with "--force".
- killall generates a scary warning message, and pauses to give
the user a chance to abort.
Diffs (updated)
-----
src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
Diff: https://reviews.apache.org/r/19159/diff/
Testing
-------
Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
[sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
============================= test session starts =============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 26 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py .....
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ..
src/test/python/apache/aurora/client/commands/test_update.py ...
========================= 26 passed in 11.34 seconds ==========================
src.test.python.apache.aurora.client.commands.core ..... SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 19159: Add killall.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/#review37101
-----------------------------------------------------------
Ship it!
src/main/python/apache/aurora/client/commands/core.py
<https://reviews.apache.org/r/19159/#comment68399>
kill newline
src/test/python/apache/aurora/client/commands/test_kill.py
<https://reviews.apache.org/r/19159/#comment68400>
kill this line
- Maxim Khutornenko
On March 13, 2014, 7:51 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19159/
> -----------------------------------------------------------
>
> (Updated March 13, 2014, 7:51 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: aurora-260
> https://issues.apache.org/jira/browse/aurora-260
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add killall.
>
> - the kill command now requires a shards parameter.
> - the new killall command only works when run with "--force".
> - killall generates a scary warning message, and pauses to give
> the user a chance to abort.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
> src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
>
> Diff: https://reviews.apache.org/r/19159/diff/
>
>
> Testing
> -------
>
> Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
>
> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
> ============================= test session starts =============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py .....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================= 26 passed in 11.34 seconds ==========================
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 19159: Add killall.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/
-----------------------------------------------------------
(Updated March 13, 2014, 3:51 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Get rid of --force.
Bugs: aurora-260
https://issues.apache.org/jira/browse/aurora-260
Repository: aurora
Description
-------
Add killall.
- the kill command now requires a shards parameter.
- the new killall command only works when run with "--force".
- killall generates a scary warning message, and pauses to give
the user a chance to abort.
Diffs (updated)
-----
src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
Diff: https://reviews.apache.org/r/19159/diff/
Testing
-------
Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
[sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
============================= test session starts =============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 26 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py .....
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ..
src/test/python/apache/aurora/client/commands/test_update.py ...
========================= 26 passed in 11.34 seconds ==========================
src.test.python.apache.aurora.client.commands.core ..... SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 19159: Add killall.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/
-----------------------------------------------------------
(Updated March 13, 2014, 2:58 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Get rid of the force flag on killall.
Bugs: aurora-260
https://issues.apache.org/jira/browse/aurora-260
Repository: aurora
Description
-------
Add killall.
- the kill command now requires a shards parameter.
- the new killall command only works when run with "--force".
- killall generates a scary warning message, and pauses to give
the user a chance to abort.
Diffs (updated)
-----
src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
Diff: https://reviews.apache.org/r/19159/diff/
Testing
-------
Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
[sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
============================= test session starts =============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 26 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py .....
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ..
src/test/python/apache/aurora/client/commands/test_update.py ...
========================= 26 passed in 11.34 seconds ==========================
src.test.python.apache.aurora.client.commands.core ..... SUCCESS
Thanks,
Mark Chu-Carroll
Re: Review Request 19159: Add killall.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/#review37005
-----------------------------------------------------------
src/main/python/apache/aurora/client/commands/core.py
<https://reviews.apache.org/r/19159/#comment68251>
As it's implemented, the --force flag is a required option for this command. Feels redundant as killall mandatory wait period should be enough here.
I presume making kill require --shards is going to be tracked in a separate RB?
- Maxim Khutornenko
On March 12, 2014, 10:11 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19159/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 10:11 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: aurora-260
> https://issues.apache.org/jira/browse/aurora-260
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add killall.
>
> - the kill command now requires a shards parameter.
> - the new killall command only works when run with "--force".
> - killall generates a scary warning message, and pauses to give
> the user a chance to abort.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py ff0f1f8668c8c405fa3a41b70cae32004034e223
> src/test/python/apache/aurora/client/commands/test_kill.py 7639dc98bfea0663461d15e3d46f1aedd13b124f
>
> Diff: https://reviews.apache.org/r/19159/diff/
>
>
> Testing
> -------
>
> Modified the existing kill command's test suite, adding new tests of the new functionality. All pass.
>
> [sun-wukong incubator-aurora (killall)]$ ./pants src/test/python/apache/aurora/client/commands:core
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)])
> ============================= test session starts =============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
>
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py .....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
>
> ========================= 26 passed in 11.34 seconds ==========================
> src.test.python.apache.aurora.client.commands.core ..... SUCCESS
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>