You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/12 02:28:59 UTC

[GitHub] [rocketmq-operator] caigy commented on a diff in pull request #132: 【ISSUE #73】support mounting a configMap to rocketmq-dashboard

caigy commented on code in PR #132:
URL: https://github.com/apache/rocketmq-operator/pull/132#discussion_r992922312


##########
example/rocketmq_v1alpha1_console_cr.yaml:
##########
@@ -1,11 +1,47 @@
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: console-config
+data:
+  application.yml: |
+    server:
+      port: 8080
+      servlet:
+        encoding:
+          charset: UTF-8
+          enabled: true
+          force: true
+    spring:
+      application:
+        name: rocketmq-dashboard
+    logging:
+      config: classpath:logback.xml
+    rocketmq:
+      config:
+        namesrvAddrs:
+          - XXX:XXX

Review Comment:
   IMO nameserver address should be injected by rocketmq-operator, not manually configured.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org