[jira] [Commented] (REEF-248) client and driver use the same name for global.jar

["Markus Weimer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/REEF-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492758#comment-14492758 ] 

Markus Weimer commented on REEF-248:
------------------------------------

On the Driver side, that method is called in {{org.apache.reef.runtime.yarn.driver.GlobalJarUploader#call}}:

{code}
final Path pathToGlobalJar = this.uploader.uploadToJobFolder(makeGlobalJar());
{code}

That in turn calls {{org.apache.reef.runtime.yarn.driver.GlobalJarUploader#makeGlobalJar}}:

{code}
private File makeGlobalJar() throws IOException {
    final File jarFile = new File(this.fileNames.getGlobalFolderName() + this.fileNames.getJarFileSuffix());
    new JARFileMaker(jarFile).addChildren(this.fileNames.getGlobalFolder()).close();
    return jarFile;
  }
{code}

Hence, it could be as simple as choosing a different name in the first line of that method. If that works, we should add the constant to {{org.apache.reef.runtime.common.files.REEFFileNames}}

> client and driver use the same name for global.jar
> --------------------------------------------------
>
>                 Key: REEF-248
>                 URL: https://issues.apache.org/jira/browse/REEF-248
>             Project: REEF
>          Issue Type: Bug
>          Components: REEF
>            Reporter: Beysim Sezgin
>
> in file lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/UploaderToJobfolder.java
> we should choose a different name when we are uploading the jar for evaluators.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)