You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/04/21 23:46:31 UTC
Review Request 33414: Made MesosContainerizer not fail on recovery if
the destroy of orphan containers fails.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33414/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
Bugs: MESOS-2367
https://issues.apache.org/jira/browse/MESOS-2367
Repository: mesos
Description
-------
Made MesosContainerizer not fail on recovery if the destroy of orphan containers fails.
Diffs
-----
src/slave/containerizer/mesos/containerizer.hpp ae61a0fcd19f2ba808624312401f020121baf5d4
src/slave/containerizer/mesos/containerizer.cpp e4136095fca55637864f495098189ab3ad8d8fe7
Diff: https://reviews.apache.org/r/33414/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 33414: Made MesosContainerizer not fail on
recovery if the destroy of orphan containers fails.
Posted by Jie Yu <yu...@gmail.com>.
> On April 24, 2015, 7:40 p.m., Ian Downes wrote:
> > Perhaps add a test that verifies unknown orphans are cleaned up?
Added a TODO. Will think about a test later.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33414/#review81532
-----------------------------------------------------------
On April 21, 2015, 9:46 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33414/
> -----------------------------------------------------------
>
> (Updated April 21, 2015, 9:46 p.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: MESOS-2367
> https://issues.apache.org/jira/browse/MESOS-2367
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made MesosContainerizer not fail on recovery if the destroy of orphan containers fails.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp ae61a0fcd19f2ba808624312401f020121baf5d4
> src/slave/containerizer/mesos/containerizer.cpp e4136095fca55637864f495098189ab3ad8d8fe7
>
> Diff: https://reviews.apache.org/r/33414/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 33414: Made MesosContainerizer not fail on
recovery if the destroy of orphan containers fails.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33414/#review81532
-----------------------------------------------------------
Ship it!
Perhaps add a test that verifies unknown orphans are cleaned up?
src/slave/containerizer/mesos/containerizer.cpp
<https://reviews.apache.org/r/33414/#comment131927>
s/that//
src/slave/containerizer/mesos/containerizer.cpp
<https://reviews.apache.org/r/33414/#comment131924>
s/destory/destroy
- Ian Downes
On April 21, 2015, 2:46 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33414/
> -----------------------------------------------------------
>
> (Updated April 21, 2015, 2:46 p.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Bugs: MESOS-2367
> https://issues.apache.org/jira/browse/MESOS-2367
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made MesosContainerizer not fail on recovery if the destroy of orphan containers fails.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp ae61a0fcd19f2ba808624312401f020121baf5d4
> src/slave/containerizer/mesos/containerizer.cpp e4136095fca55637864f495098189ab3ad8d8fe7
>
> Diff: https://reviews.apache.org/r/33414/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>