[GitHub] [daffodil-vscode] mbeckerle commented on a diff in pull request #402: Launch Wizard - Daffodil Debugger Classpath manipulation

["mbeckerle (via GitHub)" <gi...@apache.org>]

mbeckerle commented on code in PR #402:
URL: https://github.com/apache/daffodil-vscode/pull/402#discussion_r1087283273


##########
src/launchWizard/launchWizard.ts:
##########
@@ -152,38 +152,7 @@ async function openFilePicker(description) {
       title: description,
     })
     .then(async (fileUri) => {
-      if (fileUri && fileUri[0]) {

Review Comment:
   Github won't let me comment on earlier lines. 
   
   Line 139 - it's fine for the picker to start with the workspace folder, but it needs to be able to point at any folder on the machine. E.g., I've setup classpaths to refer to jars under ~/.ivy2/local/.... which is where they get put for a dependent schema by 'sbt publishLocal'. 
   
   So navigating up and out of the workspace is needed. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org