You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/11/20 08:29:38 UTC
[GitHub] [rocketmq] hzh0425 opened a new pull request, #5548: [Issue #4330]Support broker priority election for controller mode
hzh0425 opened a new pull request, #5548:
URL: https://github.com/apache/rocketmq/pull/5548
**Make sure set the target branch to `develop`**
## What is the purpose of the change
Tracking issue: #4330
Support broker priority election for controller mode
## Brief changelog
- Add a new config in brokerConfig: brokerElectionPriority, which is an important basis for the controller to choose the broker master. Under the same conditions, the broker with higher priority will be selected as master. You can set a higher priority for the broker with better machine conditions.
- In DefaultElectPolicy, previously we would sort brokers by (epoch, offset), now we will sort by (epoch, offset, electionPriority)
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] hzh0425 commented on pull request #5548: [Issue #4330]Support broker priority election for controller mode
Posted by GitBox <gi...@apache.org>.
hzh0425 commented on PR #5548:
URL: https://github.com/apache/rocketmq/pull/5548#issuecomment-1322039911
PTLA~ @RongtongJin @tsunghanjacktsai @mxsm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] tsunghanjacktsai commented on a diff in pull request #5548: [Issue #4330]Support broker priority election for controller mode
Posted by GitBox <gi...@apache.org>.
tsunghanjacktsai commented on code in PR #5548:
URL: https://github.com/apache/rocketmq/pull/5548#discussion_r1027447002
##########
common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java:
##########
@@ -336,6 +336,10 @@ public class BrokerConfig extends BrokerIdentity {
private long syncControllerMetadataPeriod = 10 * 1000;
+ // It is an important basis for the controller to choose the broker master. Under the same conditions,
Review Comment:
How about making the definition of "higher priority" clearer in the comment or the document? Like is the priority higher while the value of brokerElectionPriority is larger or smaller?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #5548: [Issue #5569]Support broker priority election for controller mode
Posted by GitBox <gi...@apache.org>.
RongtongJin merged PR #5548:
URL: https://github.com/apache/rocketmq/pull/5548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] hzh0425 commented on a diff in pull request #5548: [Issue #4330]Support broker priority election for controller mode
Posted by GitBox <gi...@apache.org>.
hzh0425 commented on code in PR #5548:
URL: https://github.com/apache/rocketmq/pull/5548#discussion_r1027580615
##########
common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java:
##########
@@ -336,6 +336,10 @@ public class BrokerConfig extends BrokerIdentity {
private long syncControllerMetadataPeriod = 10 * 1000;
+ // It is an important basis for the controller to choose the broker master. Under the same conditions,
Review Comment:
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org