You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Srabasti (via GitHub)" <gi...@apache.org> on 2025/12/28 10:24:29 UTC
[PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Srabasti opened a new pull request, #59865:
URL: https://github.com/apache/airflow/pull/59865
This PR is to Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py referenced [https://github.com/apache/airflow/issues/59402].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "henry3260 (via GitHub)" <gi...@apache.org>.
henry3260 commented on code in PR #59865:
URL: https://github.com/apache/airflow/pull/59865#discussion_r2649867053
##########
.pre-commit-config.yaml:
##########
@@ -455,28 +450,22 @@ repos:
^airflow-core/tests/unit/utils/test_cli_util.py$|
^airflow-core/tests/unit/timetables/test_assets_timetable.py$|
^airflow-core/tests/unit/assets/test_manager.py$|
- ^airflow-core/tests/unit/jobs/test_scheduler_job.py$|
^airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py$|
^airflow-core/tests/unit/ti_deps/deps/test_runnable_exec_date_dep.py$|
^airflow-core/tests/unit/models/test_dagwarning.py$|
^airflow-core/tests/integration/otel/test_otel.py$|
^airflow-core/tests/unit/utils/test_db_cleanup.py$|
^airflow-core/tests/unit/utils/test_state.py$|
^airflow-core/tests/unit/utils/test_log_handlers.py$|
- ^airflow-core/tests/unit/utils/test_types.py$|
- ^airflow-core/tests/unit/dag_processing/test_manager.py$|
- ^airflow-core/tests/unit/dag_processing/test_processor.py$|
+ ^airflow-core/tests/unit/ti_deps/deps/test_not_previously_skipped_dep.py|
Review Comment:
```suggestion
^^airflow-core/tests/unit/ti_deps/deps/test_not_previously_skipped_dep.py$|
```
##########
.pre-commit-config.yaml:
##########
@@ -455,28 +450,22 @@ repos:
^airflow-core/tests/unit/utils/test_cli_util.py$|
^airflow-core/tests/unit/timetables/test_assets_timetable.py$|
^airflow-core/tests/unit/assets/test_manager.py$|
- ^airflow-core/tests/unit/jobs/test_scheduler_job.py$|
^airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py$|
^airflow-core/tests/unit/ti_deps/deps/test_runnable_exec_date_dep.py$|
^airflow-core/tests/unit/models/test_dagwarning.py$|
^airflow-core/tests/integration/otel/test_otel.py$|
^airflow-core/tests/unit/utils/test_db_cleanup.py$|
^airflow-core/tests/unit/utils/test_state.py$|
^airflow-core/tests/unit/utils/test_log_handlers.py$|
- ^airflow-core/tests/unit/utils/test_types.py$|
- ^airflow-core/tests/unit/dag_processing/test_manager.py$|
- ^airflow-core/tests/unit/dag_processing/test_processor.py$|
+ ^airflow-core/tests/unit/ti_deps/deps/test_not_previously_skipped_dep.py|
Review Comment:
```suggestion
^airflow-core/tests/unit/ti_deps/deps/test_not_previously_skipped_dep.py$|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on PR #59865:
URL: https://github.com/apache/airflow/pull/59865#issuecomment-3695295101
Apologies for the approval I should have check carefully
I'll be more careful next time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59865:
URL: https://github.com/apache/airflow/pull/59865#issuecomment-3707467307
### Backport failed to create: v3-1-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/20684853145'> Run details </a>
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>❌</td>
<td>v3-1-test</td>
<td><a href="https://github.com/apache/airflow/commit/c33915794e47f5b21b62e162e98a82ba56b00c53"><img src='https://img.shields.io/badge/Commit-c339157-red' alt='Commit Link'></a></td>
</tr>
</table>
You can attempt to backport this manually by running:
```bash
cherry_picker c339157 v3-1-test
```
This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.
After you have resolved the conflicts, you can continue the backport process by running:
```bash
cherry_picker --continue
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on code in PR #59865:
URL: https://github.com/apache/airflow/pull/59865#discussion_r2649623847
##########
airflow-core/pyproject.toml:
##########
@@ -130,8 +135,8 @@ dependencies = [
"rich-argparse>=1.0.0",
"rich>=13.6.0",
"setproctitle>=1.3.3",
- # The issue tracking deprecations for sqlalchemy 2 is https://github.com/apache/airflow/issues/28723
- "sqlalchemy[asyncio]>=1.4.49",
+ # SQLAlchemy >=2.0.36 fixes Python 3.13 TypingOnly import AssertionError caused by new typing attributes (__static_attributes__, __firstlineno__)
+ "sqlalchemy[asyncio]>=2.0.36",
"sqlalchemy-jsonfield>=1.0",
Review Comment:
We don’t need to commit the code from this step, since we’re only checking whether the updated changes raise any errors
Could you please revert the chnages when you have some free time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "Srabasti (via GitHub)" <gi...@apache.org>.
Srabasti commented on PR #59865:
URL: https://github.com/apache/airflow/pull/59865#issuecomment-3706686563
Static checks run locally with no errors as below.
<img width="1094" height="70" alt="image" src="https://github.com/user-attachments/assets/e7712a4f-2296-4e8b-95e8-e34d43becf3e" />
<img width="934" height="531" alt="image" src="https://github.com/user-attachments/assets/b839792b-e10e-4729-b902-a11028f4548e" />
Happy New Year!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "Srabasti (via GitHub)" <gi...@apache.org>.
Srabasti commented on code in PR #59865:
URL: https://github.com/apache/airflow/pull/59865#discussion_r2649688833
##########
.pre-commit-config.yaml:
##########
Review Comment:
Sounds good! Did this and submitted. No checks failed looks to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "Srabasti (via GitHub)" <gi...@apache.org>.
Srabasti commented on code in PR #59865:
URL: https://github.com/apache/airflow/pull/59865#discussion_r2649630871
##########
airflow-core/.pre-commit-config.yaml:
##########
@@ -419,3 +419,12 @@ repos:
^src/airflow/serialization/serialized_objects\.py$
pass_filenames: false
require_serial: true
+ - id: prevent-deprecated-sqlalchemy-usage
+ name: Prevent deprecated sqlalchemy usage
+ entry: ./scripts/ci/prek/prevent_deprecated_sqlalchemy_usage.py
+ language: python
+ files: >
+ (?x)
+ ^airflow-ctl.*\.py$|
+ ^airflow-core/tests/unit/dag_processing/test_processor.py$|
+ ^airflow-ctl/tests/.*\.py$|
Review Comment:
Good catch @Prab-27 ! Reverted the change and pushed again.
Found the same file here hence thought both places need to be changed.
I was working on test_processor.py file and it got picked up by someone else before I could raise draft PR, hence it still shows up here from the old branch. Looks like the changes did not go through for the new branch yet. Update in progress now.
Quick question - Is there a specific reason as to why the same file ".pre-commit-config.yaml" exists in multiple places?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "henry3260 (via GitHub)" <gi...@apache.org>.
henry3260 commented on code in PR #59865:
URL: https://github.com/apache/airflow/pull/59865#discussion_r2649867053
##########
.pre-commit-config.yaml:
##########
@@ -455,28 +450,22 @@ repos:
^airflow-core/tests/unit/utils/test_cli_util.py$|
^airflow-core/tests/unit/timetables/test_assets_timetable.py$|
^airflow-core/tests/unit/assets/test_manager.py$|
- ^airflow-core/tests/unit/jobs/test_scheduler_job.py$|
^airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py$|
^airflow-core/tests/unit/ti_deps/deps/test_runnable_exec_date_dep.py$|
^airflow-core/tests/unit/models/test_dagwarning.py$|
^airflow-core/tests/integration/otel/test_otel.py$|
^airflow-core/tests/unit/utils/test_db_cleanup.py$|
^airflow-core/tests/unit/utils/test_state.py$|
^airflow-core/tests/unit/utils/test_log_handlers.py$|
- ^airflow-core/tests/unit/utils/test_types.py$|
- ^airflow-core/tests/unit/dag_processing/test_manager.py$|
- ^airflow-core/tests/unit/dag_processing/test_processor.py$|
+ ^airflow-core/tests/unit/ti_deps/deps/test_not_previously_skipped_dep.py|
Review Comment:
^airflow-core/tests/unit/ti_deps/deps/test_not_previously_skipped_dep.py$|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #59865:
URL: https://github.com/apache/airflow/pull/59865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on code in PR #59865:
URL: https://github.com/apache/airflow/pull/59865#discussion_r2649627648
##########
.pre-commit-config.yaml:
##########
Review Comment:
Could you please add the file name in this hook?
I believe you accidentally added the file name in another hook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on code in PR #59865:
URL: https://github.com/apache/airflow/pull/59865#discussion_r2649617380
##########
airflow-core/.pre-commit-config.yaml:
##########
@@ -419,3 +419,12 @@ repos:
^src/airflow/serialization/serialized_objects\.py$
pass_filenames: false
require_serial: true
+ - id: prevent-deprecated-sqlalchemy-usage
+ name: Prevent deprecated sqlalchemy usage
+ entry: ./scripts/ci/prek/prevent_deprecated_sqlalchemy_usage.py
+ language: python
+ files: >
+ (?x)
+ ^airflow-ctl.*\.py$|
+ ^airflow-core/tests/unit/dag_processing/test_processor.py$|
+ ^airflow-ctl/tests/.*\.py$|
Review Comment:
we have to add the` filename` only to `.pre-commit-config.yaml` not here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "Srabasti (via GitHub)" <gi...@apache.org>.
Srabasti commented on PR #59865:
URL: https://github.com/apache/airflow/pull/59865#issuecomment-3694976286
I am travelling and do not have access to laptop shortly. Can someone rebase the PR when merging? TIA!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on code in PR #59865:
URL: https://github.com/apache/airflow/pull/59865#discussion_r2649617380
##########
airflow-core/.pre-commit-config.yaml:
##########
@@ -419,3 +419,12 @@ repos:
^src/airflow/serialization/serialized_objects\.py$
pass_filenames: false
require_serial: true
+ - id: prevent-deprecated-sqlalchemy-usage
+ name: Prevent deprecated sqlalchemy usage
+ entry: ./scripts/ci/prek/prevent_deprecated_sqlalchemy_usage.py
+ language: python
+ files: >
+ (?x)
+ ^airflow-ctl.*\.py$|
+ ^airflow-core/tests/unit/dag_processing/test_processor.py$|
+ ^airflow-ctl/tests/.*\.py$|
Review Comment:
we have to add` filename` to only `.pre-commit-config.yaml` not here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on code in PR #59865:
URL: https://github.com/apache/airflow/pull/59865#discussion_r2649625011
##########
providers/fab/pyproject.toml:
##########
@@ -73,12 +73,9 @@ dependencies = [
# In particular, make sure any breaking changes, for example any new methods, are accounted for.
"flask-appbuilder==5.0.1; python_version < '3.13'",
"flask-login>=0.6.2; python_version < '3.13'",
- # Flask-Session 0.6 add new arguments into the SqlAlchemySessionInterface constructor as well as
- # all parameters now are mandatory which make AirflowDatabaseSessionInterface incompatible with this version.
"flask-session>=0.8.0; python_version < '3.13'",
"msgpack>=1.0.0; python_version < '3.13'",
"flask-sqlalchemy>=3.0.5; python_version < '3.13'",
- "sqlalchemy>=1.4.36,<2; python_version < '3.13'",
"flask-wtf>=1.1.0; python_version < '3.13'",
Review Comment:
Could you please also revert the chnages from this file ?
We don't need to add this here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "Srabasti (via GitHub)" <gi...@apache.org>.
Srabasti commented on code in PR #59865:
URL: https://github.com/apache/airflow/pull/59865#discussion_r2649880064
##########
.pre-commit-config.yaml:
##########
@@ -455,28 +450,22 @@ repos:
^airflow-core/tests/unit/utils/test_cli_util.py$|
^airflow-core/tests/unit/timetables/test_assets_timetable.py$|
^airflow-core/tests/unit/assets/test_manager.py$|
- ^airflow-core/tests/unit/jobs/test_scheduler_job.py$|
^airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py$|
^airflow-core/tests/unit/ti_deps/deps/test_runnable_exec_date_dep.py$|
^airflow-core/tests/unit/models/test_dagwarning.py$|
^airflow-core/tests/integration/otel/test_otel.py$|
^airflow-core/tests/unit/utils/test_db_cleanup.py$|
^airflow-core/tests/unit/utils/test_state.py$|
^airflow-core/tests/unit/utils/test_log_handlers.py$|
- ^airflow-core/tests/unit/utils/test_types.py$|
- ^airflow-core/tests/unit/dag_processing/test_manager.py$|
- ^airflow-core/tests/unit/dag_processing/test_processor.py$|
+ ^airflow-core/tests/unit/ti_deps/deps/test_not_previously_skipped_dep.py|
Review Comment:
Good catch @henry3260 Updated and pushed to Git.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #59865:
URL: https://github.com/apache/airflow/pull/59865#issuecomment-3695052748
It also needs conflicts resolution which usually needs to be don by author - but I guess it can wait for your come-back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "Srabasti (via GitHub)" <gi...@apache.org>.
Srabasti commented on PR #59865:
URL: https://github.com/apache/airflow/pull/59865#issuecomment-3706864462
All checks passed successfully so far and green I see now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on PR #59865:
URL: https://github.com/apache/airflow/pull/59865#issuecomment-3694743838
OOPS !! Conflict !! Could you please rebase when you have some free time ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "henry3260 (via GitHub)" <gi...@apache.org>.
henry3260 commented on code in PR #59865:
URL: https://github.com/apache/airflow/pull/59865#discussion_r2649867053
##########
.pre-commit-config.yaml:
##########
@@ -455,28 +450,22 @@ repos:
^airflow-core/tests/unit/utils/test_cli_util.py$|
^airflow-core/tests/unit/timetables/test_assets_timetable.py$|
^airflow-core/tests/unit/assets/test_manager.py$|
- ^airflow-core/tests/unit/jobs/test_scheduler_job.py$|
^airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py$|
^airflow-core/tests/unit/ti_deps/deps/test_runnable_exec_date_dep.py$|
^airflow-core/tests/unit/models/test_dagwarning.py$|
^airflow-core/tests/integration/otel/test_otel.py$|
^airflow-core/tests/unit/utils/test_db_cleanup.py$|
^airflow-core/tests/unit/utils/test_state.py$|
^airflow-core/tests/unit/utils/test_log_handlers.py$|
- ^airflow-core/tests/unit/utils/test_types.py$|
- ^airflow-core/tests/unit/dag_processing/test_manager.py$|
- ^airflow-core/tests/unit/dag_processing/test_processor.py$|
+ ^airflow-core/tests/unit/ti_deps/deps/test_not_previously_skipped_dep.py|
Review Comment:
```suggestion
^airflow-core/tests/unit/ti_deps/deps/test_not_previously_skipped_dep.py$|
```
##########
.pre-commit-config.yaml:
##########
@@ -455,28 +450,22 @@ repos:
^airflow-core/tests/unit/utils/test_cli_util.py$|
^airflow-core/tests/unit/timetables/test_assets_timetable.py$|
^airflow-core/tests/unit/assets/test_manager.py$|
- ^airflow-core/tests/unit/jobs/test_scheduler_job.py$|
^airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py$|
^airflow-core/tests/unit/ti_deps/deps/test_runnable_exec_date_dep.py$|
^airflow-core/tests/unit/models/test_dagwarning.py$|
^airflow-core/tests/integration/otel/test_otel.py$|
^airflow-core/tests/unit/utils/test_db_cleanup.py$|
^airflow-core/tests/unit/utils/test_state.py$|
^airflow-core/tests/unit/utils/test_log_handlers.py$|
- ^airflow-core/tests/unit/utils/test_types.py$|
- ^airflow-core/tests/unit/dag_processing/test_manager.py$|
- ^airflow-core/tests/unit/dag_processing/test_processor.py$|
+ ^airflow-core/tests/unit/ti_deps/deps/test_not_previously_skipped_dep.py|
Review Comment:
```suggestion
^airflow-core/tests/unit/ti_deps/deps/test_not_previously_skipped_dep.py$|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "henry3260 (via GitHub)" <gi...@apache.org>.
henry3260 commented on code in PR #59865:
URL: https://github.com/apache/airflow/pull/59865#discussion_r2649867053
##########
.pre-commit-config.yaml:
##########
@@ -455,28 +450,22 @@ repos:
^airflow-core/tests/unit/utils/test_cli_util.py$|
^airflow-core/tests/unit/timetables/test_assets_timetable.py$|
^airflow-core/tests/unit/assets/test_manager.py$|
- ^airflow-core/tests/unit/jobs/test_scheduler_job.py$|
^airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py$|
^airflow-core/tests/unit/ti_deps/deps/test_runnable_exec_date_dep.py$|
^airflow-core/tests/unit/models/test_dagwarning.py$|
^airflow-core/tests/integration/otel/test_otel.py$|
^airflow-core/tests/unit/utils/test_db_cleanup.py$|
^airflow-core/tests/unit/utils/test_state.py$|
^airflow-core/tests/unit/utils/test_log_handlers.py$|
- ^airflow-core/tests/unit/utils/test_types.py$|
- ^airflow-core/tests/unit/dag_processing/test_manager.py$|
- ^airflow-core/tests/unit/dag_processing/test_processor.py$|
+ ^airflow-core/tests/unit/ti_deps/deps/test_not_previously_skipped_dep.py|
Review Comment:
```suggestion
^airflow-core/tests/unit/utils/test_log_handlers\.py$|^airflow-core/tests/unit/ti_deps/deps/test_not_previously_skipped_dep\.py$
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecated Query usage and update to SQLAlchemy2.0 style for test_not_previously_skipped_dep.py [airflow]
Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on PR #59865:
URL: https://github.com/apache/airflow/pull/59865#issuecomment-3706659520
Static checks are failing; you need to run the `prek` hook to fix them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org