You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@predictionio.apache.org by takezoe <gi...@git.apache.org> on 2017/06/13 03:21:51 UTC
[GitHub] incubator-predictionio pull request #391: [PIO-92] Bump HBase to 1.2.6
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio/pull/391
[PIO-92] Bump HBase to 1.2.6
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/takezoe/incubator-predictionio hbase_upgrade
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-predictionio/pull/391.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #391
----
commit 95a941083b33089e5a4d8a916881598d81eafc1e
Author: Naoki Takezoe <ta...@apache.org>
Date: 2017-06-13T03:20:07Z
[PIO-92] Bump HBase to 1.2.6
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6
Posted by takezoe <gi...@git.apache.org>.
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/391
https://github.com/apache/incubator-predictionio/pull/395
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6 (and fix dep...
Posted by takezoe <gi...@git.apache.org>.
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/391
@dszeto Thanks for your support. I updated docs in e3f8307891ae0a5b287855ad83c41379c4e1e8bc so close this pull request and [PIO-92](https://issues.apache.org/jira/projects/PIO/issues/PIO-92). I will raise a new ticket to clarify supported versions and recommended versions in docs, and continue to work on that ticket.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6 (and fix dep...
Posted by dszeto <gi...@git.apache.org>.
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/391
Sorry for the late reply. Agree we should start properly deprecating it. Regarding the inconsistency, I think we should correct `0.98.6 in https://predictionio.incubator.apache.org/install/`, and indicate right now 0.98.5 is the minimum compatible version, but it is deprecated. I think it is okay to keep a more recent HBase version in the installation instructions though, so that new users do not install an EOMed version of HBase. Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6
Posted by dszeto <gi...@git.apache.org>.
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/391
@takezoe LGTM. Mind also updating the documentation in this PR to reflect the new minimum requirement (http://predictionio.incubator.apache.org/install/)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6 (and fix dep...
Posted by takezoe <gi...@git.apache.org>.
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/391
@pferrel and I found 3 versions of HBase at least in `build.sbt` and documentation, so I'm not sure what versions are supported in the current PredictionIIO.
- 0.98.5 in https://github.com/apache/incubator-predictionio/blob/develop/storage/hbase/build.sbt
- 0.98.6 in https://predictionio.incubator.apache.org/install/
- 1.2.5 in https://predictionio.incubator.apache.org/install/install-sourcecode/
It is inconsistent. What's state that should be originally?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6
Posted by pferrel <gi...@git.apache.org>.
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/391
Is this update really required to use HBase 1.2.6? It looks like the APIs have changed without deprecate warnings. Is this true?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6
Posted by pferrel <gi...@git.apache.org>.
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/391
Actually we already have an AWS AMI with HBase 1.2.6 that works fine without any changes as far as we have seen and we do run automated tests.
Since this will require that all users of PIO upgrade hbase, why are we doing this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6 (and fix dep...
Posted by takezoe <gi...@git.apache.org>.
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/391
@dszeto @pferrel How about keeping current code but update the prerequisites section of installation guide to clarify supported versions?
About HBase, PIO supports 0.98.5 or higher, I will make a table of supported versions in the prerequisites section of document and write this in that table with other software versions.
In addition, I would like to update the installation guide to use the newest supported version (1.2.6 in HBase) for all softwares as well as HBase.
Is this alright?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio pull request #391: [PIO-92] Bump HBase to 1.2.6 (and ...
Posted by takezoe <gi...@git.apache.org>.
Github user takezoe closed the pull request at:
https://github.com/apache/incubator-predictionio/pull/391
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6
Posted by takezoe <gi...@git.apache.org>.
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/391
@dszeto Documentation updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6
Posted by takezoe <gi...@git.apache.org>.
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/391
@pferrel Following methods have been deprecated since HBase 1.0.0. Since they are still alive in HBase 1.2.6 current code works fine with 1.2.6.
I think it's not necessary to merge this request soon, but HBase 0.98 hasn't been maintained in fact. So we should lead users to upgrade to maintained versions. At first, we should announce the plan of supported versions and drop old versions after a sufficient transition period. Maybe we should do it after graduation the incubator. I would like to keep this changes keeps until that time.
But I think that there is no problem to upgrade HBase dependency to 1.2.6 from 0.98, so I will create another pull request to only do it.
```
[warn] /Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/HBEventsUtil.scala:167: method add in class Put is deprecated: see corresponding Javadoc for more information.
[warn] put.add(eBytes, col, Bytes.toBytes(v))
[warn] ^
[warn] /Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/HBEventsUtil.scala:171: method add in class Put is deprecated: see corresponding Javadoc for more information.
[warn] put.add(eBytes, col, Bytes.toBytes(v))
[warn] ^
[warn] /Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/HBLEvents.scala:45: trait HTableInterface in package client is deprecated: see corresponding Javadoc for more information.
[warn] def getTable(appId: Int, channelId: Option[Int] = None): HTableInterface =
[warn] ^
[warn] /Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/HBLEvents.scala:106: method flushCommits in trait HTableInterface is deprecated: see corresponding Javadoc for more information.
[warn] table.flushCommits()
[warn] ^
[warn] /Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/HBLEvents.scala:120: method flushCommits in trait HTableInterface is deprecated: see corresponding Javadoc for more information.
[warn] table.flushCommits()
[warn] ^
[warn] /Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/HBPEvents.scala:122: constructor HTable in class HTable is deprecated: see corresponding Javadoc for more information.
[warn] val table = new HTable(conf, tableName)
[warn] ^
[warn] /Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/StorageClient.scala:36: trait HConnection in package client is deprecated: see corresponding Javadoc for more information.
[warn] val connection: HConnection,
[warn] ^
[warn] /Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/StorageClient.scala:34: trait HConnection in package client is deprecated: see corresponding Javadoc for more information.
[warn] case class HBClient(
[warn] ^
[warn] /Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/StorageClient.scala:76: method createConnection in object HConnectionManager is deprecated: see corresponding Javadoc for more information.
[warn] val connection = HConnectionManager.createConnection(conf)
[warn] ^
[warn] /Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/StorageClient.scala:81: constructor HBaseAdmin in class HBaseAdmin is deprecated: see corresponding Javadoc for more information.
[warn] admin = new HBaseAdmin(connection)
[warn] ^
[warn] /Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/upgrade/HB_0_8_0.scala:51: trait HConnection in package client is deprecated: see corresponding Javadoc for more information.
[warn] connection: HConnection,
[warn] ^
[warn] /Users/naoki.takezoe/incubator-predictionio/storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/upgrade/Upgrade.scala:70: method flushCommits in trait HTableInterface is deprecated: see corresponding Javadoc for more information.
[warn] newTable.flushCommits()
[warn] ^
[warn] 12 warnings found
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---