[jira] [Commented] (ZOOKEEPER-2578) zkEnv.sh does not set $ZOOCFG properly if already set

["Bjorn Stange (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15488351#comment-15488351 ] 

Bjorn Stange commented on ZOOKEEPER-2578:
-----------------------------------------

I was using Zookeeper 3.4.6 to test this and encountered it by using a zookeeper-env.sh that set the value of ZOOCFG to /opt/zookeeper/zookeeper-3.4.6/conf/zoo.cfg. The final value of ZOOCFG after zkEnv.sh was evaluated was /opt/zookeeper/zookeeper-3.4.6/conf//opt/zookeeper/zookeeper-3.4.6/conf/zoo.cfg. This led me to report this bug and propose the patch.

> zkEnv.sh does not set $ZOOCFG properly if already set 
> ------------------------------------------------------
>
>                 Key: ZOOKEEPER-2578
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2578
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.2.0, 3.2.1, 3.2.2, 3.2.3, 3.3.0, 3.3.1, 3.3.2, 3.3.3, 3.3.4, 3.4.0, 3.4.1, 3.4.2, 3.4.3, 3.3.5, 3.3.6, 3.4.4, 3.4.5, 3.4.6, 3.4.7, 3.4.8, 3.4.9, 3.4.10, 3.5.0, 3.5.1, 3.5.2
>            Reporter: Bjorn Stange
>         Attachments: ZOOKEEPER-2578.patch
>
>
> In bin/zkEnv.sh The ZOOCFG variable is duplicated over itself if already set. For example, in my use case it was being set in zookeeper-env.sh. The problem seems to arise from this line (line 61 on the master branch at the time of this submission): ZOOCFG="$ZOOCFGDIR/$ZOOCFG". This overwrites the value of ZOOCFG by appending the old value to the value of ZOOCFGDIR, which is problematic if it was already initialized as the absolute path to a file. The behavior of overwriting the value of the variable in this way seems to be specific to the case where ZOOCFG is not initialized. The final state of ZOOCFG seemingly is the absolute path to the zookeeper configuration file. This behavior assumes that it is the filename only, which is where the bug arises. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)