[GitHub] [superset] rusackas commented on a diff in pull request #19754: feat: deprecate old API on core superset fave_dashboards

[GitBox <gi...@apache.org>]

rusackas commented on code in PR #19754:
URL: https://github.com/apache/superset/pull/19754#discussion_r854393586


##########
superset-frontend/src/profile/components/Favorites.tsx:
##########
@@ -17,12 +17,13 @@
  * under the License.
  */
 import React from 'react';
+import rison from 'rison';
 import moment from 'moment';
 import { t } from '@superset-ui/core';
 
 import TableLoader from '../../components/TableLoader';
 import { Slice } from '../types';
-import { User, Dashboard } from '../../types/bootstrapTypes';

Review Comment:
   I think this PR removes the last reference to this type. Think it's fair game to delete it? If not, we should add a deprecation comment on it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org