You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/26 15:38:55 UTC

[GitHub] dawidwys opened a new pull request #7177: [FLINK-7599] Support for aggregates in MATCH_RECOGNIZE

dawidwys opened a new pull request #7177: [FLINK-7599] Support for aggregates in MATCH_RECOGNIZE
URL: https://github.com/apache/flink/pull/7177
 
 
   ## What is the purpose of the change
   
   This change allows using aggregates in MEASURES and DEFINE clauses of MATCH_RECOGNIZE in sql.
   
   ## Brief change log
    - Split `AggregateUtil#transformToAggregateFunctions`
    - generating code for aggregates in `org.apache.flink.table.codegen.MatchCodeGenerator.AggBuilder`
    - extended verification of aggregates' operands in `org.apache.flink.table.codegen.PatternVariableFinder` that checks for operands in udags
   
    Still missing:
    - support for `open/close` methods (depends on #7110)
    - do not support distinct aggregates (depends on https://issues.apache.org/jira/browse/CALCITE-2707) 
    - updated documentation
   
   ## Verifying this change
   
   Added tests:
   * `org.apache.flink.table.match.MatchOperatorValidationTest#testAggregatesOnMultiplePatternVariablesNotSupported`
   * `org.apache.flink.table.runtime.stream.sql.MatchRecognizeITCase#testCepAggregates`
   * `org.apache.flink.table.`match`.MatchOperatorValidationTest#testAggregatesOnMultiplePatternVariablesNotSupportedInUDAGs`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services