[GitHub] [arrow] n3world commented on pull request #10202: ARROW-12673: [C++] Add parser handler for incorrect column counts

[GitBox <gi...@apache.org>]

n3world commented on pull request #10202:
URL: https://github.com/apache/arrow/pull/10202#issuecomment-836746945


   > Like @westonpace it seems to me that this is adding a lot of complexity. I would be ok with an option to treat missing columns as null.
   
   Is the complexity you don't like the callback function or the ability to add a field with any value and not just null?
   As for only allowing null fields to be added the minor complexity there is that the value of null are configurable so empty string could be removed from that list and because of the division between parser and converter there is currently no way for the parser to say this value is null. A null bit could be added to ParsedValueDesc to indicate this is a null value.
   As for the callback that is actually more geared towards [ARROW-12673](https://issues.apache.org/jira/browse/ARROW-12673), which is actually the functionality I started to implement and then stumbled across [ARROW-12001](https://issues.apache.org/jira/browse/ARROW-12001) and tagged that ticket in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org