[GitHub] [flink] pnowojski commented on a change in pull request #10539: [FLINK-14952][network] Solve the issue of exceeding memory limits when using mmap blocking partition

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #10539: [FLINK-14952][network] Solve the issue of exceeding memory limits when using mmap blocking partition
URL: https://github.com/apache/flink/pull/10539#discussion_r357039790
 
 

 ##########
 File path: docs/_includes/generated/netty_shuffle_environment_configuration.html
 ##########
 @@ -26,6 +26,12 @@
             <td>Boolean</td>
             <td>Boolean flag indicating whether the shuffle data will be compressed for blocking shuffle mode. Note that data is compressed per buffer and compression can incur extra CPU overhead, so it is more effective for IO bounded scenario when data compression ratio is high.</td>
         </tr>
+        <tr>
+            <td><h5>taskmanager.network.bounded-blocking-subpartition-type</h5></td>
+            <td style="word-wrap: break-word;">"file"</td>
+            <td>String</td>
+            <td>The bounded blocking subpartition type, either "mmap" or "file". The "auto" means selecting the propertytype automatically based on system memory architecture (64 bit for mmap and 32 bit for file). Also note that the memoryusage of mmap is not accounted by configured memory limits, but some resource frameworks like yarn would track this memoryusage and kill the container once memory exceeding some threshold.</td>
 
 Review comment:
   you are missing a space in places where you are contacting the strings.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services