You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/05/06 05:43:43 UTC

[GitHub] [trafficserver] maskit commented on pull request #8809: Change HttpSM.cc from using Debug() to new interface, Dbg().

maskit commented on PR #8809:
URL: https://github.com/apache/trafficserver/pull/8809#issuecomment-1119278084

   If we change "ip-allow" to "ip_allow", we should change ones in IPAllow.cc, HttpTransact.cc, and ip_allow.test.py as well.
   
   > I marked this for backport to 9.2, since it seems likely there will be later changes to HttpSM.cc that will have to be backported to 9.2.
   
   I understand that would make backporting other changes easy but isn't the change for "ip-allow" technically an incompatible change? I personally don't mind changing debug tag names on a minor release though.
   
   In either case, we should probably make the change for "ip-allow" separately on another PR for change logs and release notes. We can discuss about the incompatibility on the PR, and that would tell whether we can backport this to 9.x.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org