You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "lsm1 (via GitHub)" <gi...@apache.org> on 2023/08/02 11:54:42 UTC
[GitHub] [kyuubi] lsm1 opened a new pull request, #5128: [KYUUBI #5105][Bug] getColumns gets duplicate column names when Spark integrates with Iceberg
lsm1 opened a new pull request, #5128:
URL: https://github.com/apache/kyuubi/pull/5128
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
close #5105
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #5128: [KYUUBI #5105][Bug] getColumns gets duplicate column names when Spark integrates with Iceberg
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5128:
URL: https://github.com/apache/kyuubi/pull/5128#issuecomment-1664867530
Thanks, merged to master/1.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] cxzl25 commented on a diff in pull request #5128: [KYUUBI #5105][Bug] getColumns gets duplicate column names when Spark integrates with Iceberg
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #5128:
URL: https://github.com/apache/kyuubi/pull/5128#discussion_r1282612935
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/util/SparkCatalogUtils.scala:
##########
@@ -137,7 +137,7 @@ object SparkCatalogUtils extends Logging {
listAllNamespaces(catalog).filter { ns =>
val quoted = ns.map(quoteIfNeeded).mkString(".")
schemaPattern.r.pattern.matcher(quoted).matches()
- }.distinct
+ }.map(_.toList).toList.distinct.map(_.toArray).toArray
Review Comment:
```scala
scala> Array(Array("default"),Array("default")).distinct
res0: Array[Array[String]] = Array(Array(default), Array(default))
```
```scala
scala> Array(Array("default"),Array("default")).map(_.toList).toList.distinct.map(_.toArray).toArray
res1: Array[Array[String]] = Array(Array(default))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #5128: [KYUUBI #5105][Bug] getColumns gets duplicate column names when Spark integrates with Iceberg
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5128:
URL: https://github.com/apache/kyuubi/pull/5128#issuecomment-1662188770
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/5128?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5128](https://app.codecov.io/gh/apache/kyuubi/pull/5128?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (84be7fd) into [master](https://app.codecov.io/gh/apache/kyuubi/commit/998b5d53493af836bd6d2e06e82842491935aea4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (998b5d5) will **not change** coverage.
> Report is 13 commits behind head on master.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #5128 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 564 566 +2
Lines 31293 31531 +238
Branches 4095 4116 +21
=======================================
- Misses 31293 31531 +238
```
| [Files Changed](https://app.codecov.io/gh/apache/kyuubi/pull/5128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/kyuubi/engine/spark/util/SparkCatalogUtils.scala](https://app.codecov.io/gh/apache/kyuubi/pull/5128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay91dGlsL1NwYXJrQ2F0YWxvZ1V0aWxzLnNjYWxh) | `0.00% <0.00%> (ø)` | |
... and [21 files with indirect coverage changes](https://app.codecov.io/gh/apache/kyuubi/pull/5128/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 closed pull request #5128: [KYUUBI #5105][Bug] getColumns gets duplicate column names when Spark integrates with Iceberg
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #5128: [KYUUBI #5105][Bug] getColumns gets duplicate column names when Spark integrates with Iceberg
URL: https://github.com/apache/kyuubi/pull/5128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org