You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by kk...@apache.org on 2020/06/05 12:20:37 UTC
[flink] branch release-1.11 updated: [FLINK-18048] Fix --host
option for standalone application cluster
This is an automated email from the ASF dual-hosted git repository.
kkloudas pushed a commit to branch release-1.11
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/release-1.11 by this push:
new 39e3d6a [FLINK-18048] Fix --host option for standalone application cluster
39e3d6a is described below
commit 39e3d6ad6ce25bc94a9515362a96c229f3d0c590
Author: wangyang0918 <da...@alibaba-inc.com>
AuthorDate: Mon Jun 1 17:30:12 2020 +0800
[FLINK-18048] Fix --host option for standalone application cluster
This closes #12426.
---
.../StandaloneApplicationClusterConfigurationParserFactory.java | 1 +
...tandaloneApplicationClusterConfigurationParserFactoryTest.java | 8 ++++++++
2 files changed, 9 insertions(+)
diff --git a/flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneApplicationClusterConfigurationParserFactory.java b/flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneApplicationClusterConfigurationParserFactory.java
index cc120c0..6c3bfb3 100644
--- a/flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneApplicationClusterConfigurationParserFactory.java
+++ b/flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneApplicationClusterConfigurationParserFactory.java
@@ -68,6 +68,7 @@ public class StandaloneApplicationClusterConfigurationParserFactory implements P
options.addOption(JOB_CLASS_NAME_OPTION);
options.addOption(JOB_ID_OPTION);
options.addOption(DYNAMIC_PROPERTY_OPTION);
+ options.addOption(HOST_OPTION);
options.addOption(CliFrontendParser.SAVEPOINT_PATH_OPTION);
options.addOption(CliFrontendParser.SAVEPOINT_ALLOW_NON_RESTORED_OPTION);
diff --git a/flink-container/src/test/java/org/apache/flink/container/entrypoint/StandaloneApplicationClusterConfigurationParserFactoryTest.java b/flink-container/src/test/java/org/apache/flink/container/entrypoint/StandaloneApplicationClusterConfigurationParserFactoryTest.java
index a12de88..9c7e94c 100644
--- a/flink-container/src/test/java/org/apache/flink/container/entrypoint/StandaloneApplicationClusterConfigurationParserFactoryTest.java
+++ b/flink-container/src/test/java/org/apache/flink/container/entrypoint/StandaloneApplicationClusterConfigurationParserFactoryTest.java
@@ -233,4 +233,12 @@ public class StandaloneApplicationClusterConfigurationParserFactoryTest extends
assertThat(savepointRestoreSettings.allowNonRestoredState(), is(true));
}
+ @Test
+ public void testHostOption() throws FlinkParseException {
+ final String hostName = "user-specified-hostname";
+ final String[] args = {"--configDir", confDirPath, "--job-classname", "foobar", "--host", hostName};
+ final StandaloneApplicationClusterConfiguration applicationClusterConfiguration = commandLineParser.parse(args);
+ assertThat(applicationClusterConfiguration.getHostname(), is(hostName));
+ }
+
}