You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2012/07/02 19:27:23 UTC

[jira] [Created] (WICKET-4635) Improve JavaScript files by applying common JSHint rules

Martin Grigorov created WICKET-4635:
---------------------------------------

             Summary: Improve JavaScript files by applying common JSHint rules 
                 Key: WICKET-4635
                 URL: https://issues.apache.org/jira/browse/WICKET-4635
             Project: Wicket
          Issue Type: Improvement
          Components: wicket, wicket-datetime, wicket-extensions
    Affects Versions: 6.0.0-beta2
            Reporter: Martin Grigorov
            Assignee: Martin Grigorov


We can improve the quality of our .js files by using JSHint to check for some common best practices.

Recently I've added grunt.js in the root folder of the project. It can be used to run JSHint and QUnit tests on the command line after making changes to any of the .js files. For now it process only wicket-event-jquery.js, wicket-ajax-jquery.js and wicket-ajax-debug-jquery.js. We should add all .js files from all modules.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-4635) Improve JavaScript files by applying common JSHint rules

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-4635.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 6.0.0-RC1

All .js files from the following modules have been linted:
-core, -extensions, -datetime, native WebSocket, atmosphere and grunt.js itself.
                
> Improve JavaScript files by applying common JSHint rules 
> ---------------------------------------------------------
>
>                 Key: WICKET-4635
>                 URL: https://issues.apache.org/jira/browse/WICKET-4635
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket, wicket-datetime, wicket-extensions
>    Affects Versions: 6.0.0-beta2
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>             Fix For: 6.0.0-RC1
>
>
> We can improve the quality of our .js files by using JSHint to check for some common best practices.
> Recently I've added grunt.js in the root folder of the project. It can be used to run JSHint and QUnit tests on the command line after making changes to any of the .js files. For now it process only wicket-event-jquery.js, wicket-ajax-jquery.js and wicket-ajax-debug-jquery.js. We should add all .js files from all modules.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira