[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #323: HDDS-2686. Use protobuf 3 instead of protobuf 2

[GitBox <gi...@apache.org>]

anuengineer commented on a change in pull request #323: HDDS-2686. Use protobuf 3 instead of protobuf 2
URL: https://github.com/apache/hadoop-ozone/pull/323#discussion_r354949057
 
 

 ##########
 File path: hadoop-hdds/common/src/main/proto/SCMSecurityProtocol.proto
 ##########
 @@ -21,6 +21,7 @@
  * Please see http://wiki.apache.org/hadoop/Compatibility
  * for what changes are allowed for a *unstable* .proto interface.
  */
+syntax = "proto2";
 
 Review comment:
   Compiling only. So no, we cannot move to Protoc3 in this patch. That would require some serious testing and work. But it is an amazing goal to have. I have probably try to change the DN protocol since it is on GRPC and independent of Hadoop RPC libraries. Eventually, we will get there, but baby steps.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org