[GitHub] [flink] snuyanzin commented on a diff in pull request #18109: [FLINK-25284][Table SQL / API] Add proportion of null values to generate with datagen

["snuyanzin (via GitHub)" <gi...@apache.org>]

snuyanzin commented on code in PR #18109:
URL: https://github.com/apache/flink/pull/18109#discussion_r1202427646


##########
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/DataGenConnectorOptions.java:
##########
@@ -109,5 +110,12 @@ public class DataGenConnectorOptions {
                     .noDefaultValue()
                     .withDescription("End value of sequence generator.");
 
+    /** Placeholder {@link ConfigOption}. Not used for retrieving values. */
+    public static final ConfigOption<Float> FIELD_NULL_RATE =
+            ConfigOptions.key(String.format("%s.#.%s", FIELDS, NULL_RATE))

Review Comment:
   good catch, will use `ConfigOptions.key` since most of options use it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org