[GitHub] [spark] srowen commented on a change in pull request #24736: [SPARK-27862][Build] Move to json4s 3.6.5

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24736: [SPARK-27862][Build] Move to json4s 3.6.5
URL: https://github.com/apache/spark/pull/24736#discussion_r288548800
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -762,14 +762,19 @@
       <dependency>
         <groupId>org.json4s</groupId>
         <artifactId>json4s-jackson_${scala.binary.version}</artifactId>
-        <version>3.5.3</version>
+        <version>3.6.5</version>
         <exclusions>
           <exclusion>
             <groupId>com.fasterxml.jackson.core</groupId>
             <artifactId>*</artifactId>
           </exclusion>
         </exclusions>
       </dependency>
+      <dependency>
+        <groupId>org.scala-lang.modules</groupId>
+        <artifactId>scala-xml_${scala.binary.version}</artifactId>
+        <version>1.2.0</version>
 
 Review comment:
   Good catch. @igreenfield concretely that means the line for scala-xml in `LICENSE-binary` should move from the BSD 3-clause section to Apache License 2.0 section above. Also we need to copy the text from https://github.com/scala/scala-xml/blob/master/NOTICE to end of `NOTICE-binary`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org