[GitHub] [arrow] paleolimbot commented on a change in pull request #12536: ARROW-13168: [C++][R] Enable runtime timezone database for Windows

[GitBox <gi...@apache.org>]

paleolimbot commented on a change in pull request #12536:
URL: https://github.com/apache/arrow/pull/12536#discussion_r818943619



##########
File path: r/R/arrow-package.R
##########
@@ -65,6 +65,14 @@
     # Disable multithreading on Windows
     # See https://issues.apache.org/jira/browse/ARROW-8379
     options(arrow.use_threads = FALSE)
+
+    # Try to set timezone database
+    if (requireNamespace("tzdb", quietly = TRUE)) {
+      tzdb::tzdb_initialize()
+      set_timezone_database(tzdb::tzdb_path("text"))
+    } else {
+      warning("tzdb not installed. Timezones will not be available.")
+    }

Review comment:
       I think you need to add `tzdb` to `Suggests:` (which lives in the `DESCRIPTION` file at the top level of the package)!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org