You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by di...@apache.org on 2004/07/17 21:53:57 UTC

cvs commit: ws-axis/java/src/org/apache/axis/utils XMLUtils.java

dims        2004/07/17 12:53:57

  Modified:    java/src/org/apache/axis/utils XMLUtils.java
  Log:
  Fix for AXIS-1202 - Memory leak in classe org.apache.axis.utils.XMLUtils
  
  Notes:
  - This could be the root cause for Peter's OOM's (AXIS-1423 : http://nagoya.apache.org/jira/browse/AXIS-1423)
  
  Revision  Changes    Path
  1.95      +6 -4      ws-axis/java/src/org/apache/axis/utils/XMLUtils.java
  
  Index: XMLUtils.java
  ===================================================================
  RCS file: /home/cvs/ws-axis/java/src/org/apache/axis/utils/XMLUtils.java,v
  retrieving revision 1.94
  retrieving revision 1.95
  diff -u -r1.94 -r1.95
  --- XMLUtils.java	17 Jun 2004 21:48:39 -0000	1.94
  +++ XMLUtils.java	17 Jul 2004 19:53:57 -0000	1.95
  @@ -38,6 +38,7 @@
   import org.xml.sax.SAXException;
   import org.xml.sax.SAXParseException;
   import org.xml.sax.XMLReader;
  +import org.xml.sax.helpers.DefaultHandler;
   
   import javax.xml.namespace.QName;
   import javax.xml.parsers.DocumentBuilder;
  @@ -81,6 +82,7 @@
       private static DocumentBuilderFactory dbf = getDOMFactory();
       private static SAXParserFactory       saxFactory;
       private static Stack                  saxParsers = new Stack();
  +    private static DefaultHandler doNothingContentHandler = new DefaultHandler();
   
       private static String EMPTY = "";
       private static ByteArrayInputStream bais = new ByteArrayInputStream(EMPTY.getBytes());
  @@ -233,10 +235,10 @@
           try{
               XMLReader xmlReader= parser.getXMLReader();
               if(null != xmlReader){
  -//                xmlReader.setContentHandler(doNothingContentHandler);
  -//                xmlReader.setDTDHandler(doNothingContentHandler);
  -//                xmlReader.setEntityResolver(doNothingContentHandler);
  -//                xmlReader.setErrorHandler(doNothingContentHandler);
  +                xmlReader.setContentHandler(doNothingContentHandler);
  +                xmlReader.setDTDHandler(doNothingContentHandler);
  +                xmlReader.setEntityResolver(doNothingContentHandler);
  +                xmlReader.setErrorHandler(doNothingContentHandler);
                   synchronized (XMLUtils.class ) {
                       saxParsers.push(parser);
                   }