You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/12 16:57:28 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #12865: ARROW-14477: [C++] Timezone-aware kernels should also handle offset strings

pitrou commented on code in PR #12865:
URL: https://github.com/apache/arrow/pull/12865#discussion_r848662372


##########
cpp/src/arrow/vendored/datetime/tz.h:
##########
@@ -294,6 +294,40 @@ struct zoned_traits
 {
 };
 
+class OffsetZone {

Review Comment:
   As a policy, we shouldn't add our own code inside vendored libraries. Just put it somewhere else in the source tree (for example in a `arrow/util/date_internal.h` where the vendored code would be included)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org