You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sergio Bossa (JIRA)" <ji...@apache.org> on 2013/10/09 22:28:42 UTC
[jira] [Comment Edited] (CASSANDRA-6135) Add beforeChange
Notification to Gossiper State.
[ https://issues.apache.org/jira/browse/CASSANDRA-6135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790826#comment-13790826 ]
Sergio Bossa edited comment on CASSANDRA-6135 at 10/9/13 8:27 PM:
------------------------------------------------------------------
bq. That we can think of so far
Well, if that could change, meaning that the caller may rely on the VV being unchanged, checking for subscribers will not make it right; actually, it will make things worse, because the side effect will only spread under certain conditions (i.e. when there are subscribers), while if we always bump the version, our side effect will always propagate and the caller will fail fast.
That said, I can certainly make that change, I'm just warning about future bugs and set expectations right :)
was (Author: sbtourist):
bq. That we can think of so far
Well, if that could change, meaning that the caller may rely on the VV being unchanged, checking for subscribers will not make it right; actually, it will make things worse, because the side effect will only spread under certain conditions (i.e. long running subscribers), while if we always bump the version, our side effect will always propagate and the caller will fail fast.
That said, I can certainly make that change, I'm just warning about future bugs and set expectations right :)
> Add beforeChange Notification to Gossiper State.
> ------------------------------------------------
>
> Key: CASSANDRA-6135
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6135
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Benjamin Coverston
> Assignee: Sergio Bossa
> Attachments: 0001-New-Gossiper-notification-to-IEndpointStateChangeSub.patch, 0002-CASSANDRA-6135.diff
>
>
> We would like an internal notification to be fired before state changes happen so we can intercept them, and in some cases defer them.
--
This message was sent by Atlassian JIRA
(v6.1#6144)