[GitHub] [spark] gaborgsomogyi commented on a change in pull request #34604: [SPARK-37329][YARN] File system delegation tokens are leaked

[GitBox <gi...@apache.org>]

gaborgsomogyi commented on a change in pull request #34604:
URL: https://github.com/apache/spark/pull/34604#discussion_r779428985



##########
File path: core/src/main/scala/org/apache/spark/deploy/security/HadoopFSDelegationTokenProvider.scala
##########
@@ -145,6 +145,12 @@ private[deploy] class HadoopFSDelegationTokenProvider
         interval
       }.toOption
     }
+    // cancel the temporary delegation tokens to avoid leakage
+    creds.getAllTokens.asScala.foreach {
+      case id: AbstractDelegationTokenIdentifier => id.cancel(hadoopConf)

Review comment:
       @jojochuang can you make the change to merge this? You've made the majority of the work already :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org