You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@causeway.apache.org by "Daniel Keir Haywood (Jira)" <ji...@apache.org> on 2023/12/12 12:01:00 UTC

[jira] [Closed] (CAUSEWAY-3544) [WON'T FIX] Refactor preInteractionClosed calling of completeAndPublishCommand, instead treat similar to audit trail publisher.

     [ https://issues.apache.org/jira/browse/CAUSEWAY-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Keir Haywood closed CAUSEWAY-3544.
-----------------------------------------

> [WON'T FIX] Refactor preInteractionClosed calling of completeAndPublishCommand, instead treat similar to audit trail publisher.
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAUSEWAY-3544
>                 URL: https://issues.apache.org/jira/browse/CAUSEWAY-3544
>             Project: Causeway
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.0-RC2
>            Reporter: Daniel Keir Haywood
>            Assignee: Daniel Keir Haywood
>            Priority: Minor
>             Fix For: 2.0.0-RC4
>
>
> In InteractionServiceDefault#preInteractionClosed() we currently call the `completeAndPublishCurrentCommand` first, and then later we loop around all transactionBoundaryAwareBeans callback, tell them to do their stuff.  One of those is auditing (EntityChangePublishing).
> I don't see any reason that command publishing is any different from auditing, so I think we should refactor to use the same callbacks..
> Note that ExecutionPubilshing is not a transactionally aware aspect ... we publish that more eagerly, as each action invocation (or property edit) is executed .



--
This message was sent by Atlassian Jira
(v8.20.10#820010)