You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/02/11 00:36:10 UTC

Review Request 43446: Update module tests to pass shared_ptrs to 'StartSlave'.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43446/
-----------------------------------------------------------

Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Bugs: MESOS-4633
    https://issues.apache.org/jira/browse/MESOS-4633


Repository: mesos


Description
-------

Makes the following changes:

* All objects passed to `StartSlave` are transformed into `shared_ptr`.
* References to the above objects are updated to reflect the different type.
* Removes `Shutdown()` in at the end of all tests, except for master tests that have a stack-allocated dependency.
* Removes manual `delete`s inside tests.
* Generally renames test variables to be more consistent (i.e. `exec` -> `executor` and `dockerContainerizer` -> `containerizer`).
* Removes extraneous spaces in `Try<PID<Slave> >` in touched lines.


Diffs
-----

  src/tests/container_logger_tests.cpp e161fd671972d365a25a5f2e238e11815e574164 
  src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 
  src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 

Diff: https://reviews.apache.org/r/43446/diff/


Testing
-------

Tests are run at the very, very end of this review chain.


Thanks,

Joseph Wu