[jira] [Comment Edited] (ATLAS-1877) UI: In Lineage for Process entity process icon is not showing.

["Keval Bhatt (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ATLAS-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051636#comment-16051636 ] 

Keval Bhatt edited comment on ATLAS-1877 at 6/16/17 9:10 AM:
-------------------------------------------------------------

[~xiaqinglin] In master we checking only one level of [superType | https://github.com/apache/incubator-atlas/blob/master/dashboardv2/public/js/views/graph/LineageLayoutView.js#L128]. so if any entity which is derived from more then 1 level and Process entity is not in first level the it will not work. To fix this issue you should check for current entity is process or not and if it is not then search for all the nested superType to check whether it has process entity in it.

Example:
{code}
[{
    category:"ENTITY",
    superTypes:['e2'],
    name:"e1",
    ............
},
{
    category:"ENTITY",
    superTypes:['e3'],
    name:"e2",
    ..............
},{
    category:"ENTITY",
    superTypes:[''Process"],
    name:"e3",
    ..................
},,{
    category:"ENTITY",
    superTypes:[],
    name:"Process",
    ..................
}]
{code}

So now to check *e1* entity is process or not, you need to check in e2 -> e3 and in e3 you have process entity so e1 is process.


To get all the nested type please follow this [Utility|https://github.com/apache/incubator-atlas/blob/master/dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js#L245] 


was (Author: kevalbhatt18):
[~xiaqinglin] In master we checking only one level of [superType | https://github.com/apache/incubator-atlas/blob/master/dashboardv2/public/js/views/graph/LineageLayoutView.js#L128]. so if any entity which is derived from more then 1 level and Process entity is not in first level the it will not work. To fix this issue you should check for current entity is process or not and if it is not then search for all the nested superType to check whether it has process entity in it.

Example:
{code}
[{
    category:"ENTITY",
    superTypes:['e2'],
    name:"e1",
    ............
},
{
    category:"ENTITY",
    superTypes:['e3'],
    name:"e2",
    ..............
},{
    category:"ENTITY",
    superTypes:[''Process"],
    name:"e3",
    ..................
},,{
    category:"ENTITY",
    superTypes:[],
    name:"Process",
    ..................
}]
{code}

So now to check *e1* entity is process or not, you need to check in e2 -> e3 and in e3 you have process entity so e1 is process.

> UI: In Lineage for Process entity process icon is not showing.
> --------------------------------------------------------------
>
>                 Key: ATLAS-1877
>                 URL: https://issues.apache.org/jira/browse/ATLAS-1877
>             Project: Atlas
>          Issue Type: Bug
>    Affects Versions: 0.8-incubating
>            Reporter: Keval Bhatt
>            Assignee: qinglin,xia
>              Labels: atlas
>             Fix For: trunk, 0.9-incubating
>
>         Attachments: 0001-fix-ATLAS-1877.patch, Process_Icon_Fixed.png, wrong_process_icon.png
>
>
> UI should check Process entity in all parent superType, right know its checking for only 1 level
> Step to reproduce :
> # Run quickstart
> # Create entity of type Process and while creating process select time_dim (Table entity) as a input and output.
> # Now got to sales_fact_monthly_mv entity and you will see new output (Please find attached screenshot )



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)