You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/09/18 08:23:14 UTC

[GitHub] [incubator-kvrocks] PragmaTwice opened a new issue, #884: Add redis-benchmark to CI

PragmaTwice opened a new issue, #884:
URL: https://github.com/apache/incubator-kvrocks/issues/884

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   We can design a phase in CI (triggerred by PR or daily) to automatically run redis-benchmark to test the stability and performance of kvrocks under a certain commit, and report it while an evident performance downgrade or crash occurs in the benchmark phase.
   
   ### Solution
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] aleksraiden commented on issue #884: Add redis-benchmark to CI

Posted by GitBox <gi...@apache.org>.
aleksraiden commented on issue #884:
URL: https://github.com/apache/incubator-kvrocks/issues/884#issuecomment-1264686171

   Thanks, gets to work


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] aleksraiden commented on issue #884: Add redis-benchmark to CI

Posted by GitBox <gi...@apache.org>.
aleksraiden commented on issue #884:
URL: https://github.com/apache/incubator-kvrocks/issues/884#issuecomment-1264625891

   I thinked about this feature. Very cool, we need this tests.
   
   IMHO, we can add to x.py file something like this:
   
   `./x.py benchmark --bench-path=` 
   
   with default value of client/request etc. 
   
   In CI script, we change step "Install redis" and copy redis-benchmark into  $HOME/local/bin/.
   
   Then we use -q options and run benchmark in quite format, just output req/sec. 
   
   In a first stage this numbers only for view, but maybe we can store a some historical tests results into file and after bench are running, check deviations. 
   
   So, I'am not a excellent C/Python/CI dev, but I can try to realize this step-by-step


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #884: Add redis-benchmark to CI

Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on issue #884:
URL: https://github.com/apache/incubator-kvrocks/issues/884#issuecomment-1264673586

   Thanks for your interest, please go ahead!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org