You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/11/18 22:58:21 UTC

DO NOT REPLY [Bug 50293] New: javax.el.CompositeELResolver synchronization issue

https://issues.apache.org/bugzilla/show_bug.cgi?id=50293

           Summary: javax.el.CompositeELResolver synchronization issue
           Product: Tomcat 7
           Version: trunk
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Servlet & JSP API
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: robert_goff828@yahoo.com


Created an attachment (id=26310)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26310)
Synchronize change in CompositeELResolver.add

The javax.el.CompositeELResolver.add method needs to synchronize around the
update to the resolvers.  If two threads call add, then it is possible for both
threads get past the size check, then one thread updates the size, and when the
next thread tries to update the size, it fails with an
ArrayIndexOutOfBoundsException.

Also, it makes sense to increase the default size of the ELResolver array since
even the jasper EL adds 5 ELResolvers.  I propose a default of 8.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 50293] javax.el.CompositeELResolver synchronization issue

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50293

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Mark Thomas <ma...@apache.org> 2010-11-19 13:32:24 EST ---
The EL spec states the ELContexts are not thread-safe. By extension, neither
are ELResolvers.

The point regarding increasing the default size is a valid one. I have
increased it to 8 for 7.0.5 onwards as per your suggestion.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 50293] javax.el.CompositeELResolver synchronization issue

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50293

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |qiuyunzhong@hotmail.com

--- Comment #2 from Mark Thomas <ma...@apache.org> 2012-02-05 19:18:05 UTC ---
*** Bug 52580 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org