You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "robreeves (via GitHub)" <gi...@apache.org> on 2025/03/28 21:40:32 UTC
[PR] [SPARK-51660][CORE] Gracefully handle when MDC is not supported [spark]
robreeves opened a new pull request, #50452:
URL: https://github.com/apache/spark/pull/50452
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This improves the handling when MDC is not supported.
### Why are the changes needed?
In https://github.com/apache/spark/pull/35141 it added handling to gracefully handle when MDC is not available. It catches NoSuchFieldError, which is thrown during MDC initialization. This will work for the first task. If a second task runs it will not throw a NoSuchFieldError. Instead it throws NoClassDefFoundError. Then the job will hang indefinitely. This improves the fix so it works for all tasks instead of just the first one.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, it fixes a bug. It also changes a log message to include the exception for easier debugging.
### How was this patch tested?
I tested it manually in spark-shell by manually throwing `NoSuchFieldError`. It logs this message and does not hang.
```
25/03/28 14:11:48 INFO Executor: MDC is not supported.
java.lang.NoSuchFieldError: this is a test
at org.apache.spark.executor.Executor.liftedTree1$1(Executor.scala:118)
at org.apache.spark.executor.Executor.mdcIsSupported$lzycompute(Executor.scala:114)
at org.apache.spark.executor.Executor.mdcIsSupported(Executor.scala:113)
at org.apache.spark.executor.Executor.org$apache$spark$executor$Executor$$setMDCForTask(Executor.scala:948)
at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:584)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
```
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51660][CORE] Gracefully handle when MDC is not supported [spark]
Posted by "robreeves (via GitHub)" <gi...@apache.org>.
robreeves commented on PR #50452:
URL: https://github.com/apache/spark/pull/50452#issuecomment-2779784960
@dongjoon-hyun gentle ping on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51660][CORE] Gracefully handle when MDC is not supported [spark]
Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm commented on code in PR #50452:
URL: https://github.com/apache/spark/pull/50452#discussion_r2021561333
##########
core/src/main/scala/org/apache/spark/executor/Executor.scala:
##########
@@ -110,6 +110,21 @@ private[spark] class Executor(
// finish downloading dependencies.
private val updateDependenciesLock = new ReentrantLock()
+ private lazy val mdcIsSupported = {
+ try {
+ // This tests if any class initialization error is thrown
+ val testKey = System.nanoTime().toString
+ MDC.put(testKey, "testValue")
+ MDC.remove(testKey)
+
+ true
+ } catch {
+ case t: Throwable =>
+ logInfo("MDC is not supported.", t)
+ false
+ }
+ }
+
Review Comment:
QQ: Can this not be moved to the companion object ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51660][CORE] Gracefully handle when MDC is not supported [spark]
Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm commented on PR #50452:
URL: https://github.com/apache/spark/pull/50452#issuecomment-2799830954
Merged to master.
Thanks for fixing this @robreeves !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51660][CORE] Gracefully handle when MDC is not supported [spark]
Posted by "robreeves (via GitHub)" <gi...@apache.org>.
robreeves commented on code in PR #50452:
URL: https://github.com/apache/spark/pull/50452#discussion_r2021913156
##########
core/src/main/scala/org/apache/spark/executor/Executor.scala:
##########
@@ -110,6 +110,21 @@ private[spark] class Executor(
// finish downloading dependencies.
private val updateDependenciesLock = new ReentrantLock()
+ private lazy val mdcIsSupported = {
+ try {
+ // This tests if any class initialization error is thrown
+ val testKey = System.nanoTime().toString
+ MDC.put(testKey, "testValue")
+ MDC.remove(testKey)
+
+ true
+ } catch {
+ case t: Throwable =>
+ logInfo("MDC is not supported.", t)
+ false
+ }
+ }
+
Review Comment:
Good idea. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51660][CORE] Gracefully handle when MDC is not supported [spark]
Posted by "robreeves (via GitHub)" <gi...@apache.org>.
robreeves commented on PR #50452:
URL: https://github.com/apache/spark/pull/50452#issuecomment-2762623684
@dongjoon-hyun please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51660][CORE] Gracefully handle when MDC is not supported [spark]
Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm closed pull request #50452: [SPARK-51660][CORE] Gracefully handle when MDC is not supported
URL: https://github.com/apache/spark/pull/50452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51660][CORE] Gracefully handle when MDC is not supported [spark]
Posted by "robreeves (via GitHub)" <gi...@apache.org>.
robreeves commented on PR #50452:
URL: https://github.com/apache/spark/pull/50452#issuecomment-2787390957
@viirya can you take a look since you reviewed the original PR https://github.com/apache/spark/pull/35141?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org