[jira] [Commented] (OPENNLP-1160) avoid letting users specify CachedFeatureGeneratorFactory in XML config

["Koji Sekiguchi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306169#comment-16306169 ] 

Koji Sekiguchi commented on OPENNLP-1160:
-----------------------------------------

I'll suggest adding `cache` attribute in the most top tag:

{code:xml}
<featureGenerators cache="true" name="namefind">...</featureGenerators>
{code}


> avoid letting users specify CachedFeatureGeneratorFactory in XML config
> -----------------------------------------------------------------------
>
>                 Key: OPENNLP-1160
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1160
>             Project: OpenNLP
>          Issue Type: Improvement
>          Components: Formats, Name Finder
>    Affects Versions: 1.8.3
>            Reporter: Koji Sekiguchi
>            Assignee: Koji Sekiguchi
>            Priority: Minor
>
> This is similar to OPENNLP-1159. When I'm working on OPENNLP-1154, I think we should do it for better use.
> I'd like to implement this as an independent ticket from OPENNLP-1154 and OPENNLP-1159 to make patch easy to read.
> And this ticket is somewhat different from OPENNLP-1159 as users must be able to control the framework uses CachedFeatureGeneratorFactory or not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)