You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by filmaj <gi...@git.apache.org> on 2017/06/27 17:56:43 UTC
[GitHub] cordova-android pull request #391: WIP: E2E test tweaks + moar testing on Wi...
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-android/pull/391
WIP: E2E test tweaks + moar testing on Windows
Please don't merge! Testing how appveyor behaves when we tell it to install the latest Android SDK, and run the e2e tests.
FINGERS CROSSED
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/filmaj/cordova-android e2e-test-tweaks
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/391.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #391
----
commit 2428df867c9c938e1784a2a993bfc19aa21261fa
Author: filmaj <ma...@gmail.com>
Date: 2017-06-27T17:02:38Z
CB-12950 rename npm tasks to reflect what they do (npm run unit-tests, npm run e2e-tests). main `npm test` runs linter, unit tests and e2e tests now. updated travis to run `npm test`. locked jasmine down to ~2.6.0.
commit 1c9210b638a810a03e53e89762b43220c602131b
Author: filmaj <ma...@gmail.com>
Date: 2017-06-27T17:54:47Z
consolidate gitignores.
commit bd7d006c17135d2c89294fa3144762175cace0af
Author: filmaj <ma...@gmail.com>
Date: 2017-06-27T17:55:32Z
Lets see how appveyor rolls with android sdk installation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...
Posted by alsorokin <gi...@git.apache.org>.
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-android/pull/391
Here's a JIRA issue:
https://issues.apache.org/jira/browse/CB-12960
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...
Posted by alsorokin <gi...@git.apache.org>.
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-android/pull/391
As I've already done this for plugins and have the knowledge, I can do the same thing for iOS and Android if you like, after this is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + moar testing on Wind...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/391
I just realized... on Windows, we run against both node v4 and node v6. On travis, only against node v6. We should make this consistent. Which one? The `package.json` file _does_ specify as supporting node v4+...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #391: CB-12950: E2E test tweaks + Appveyor now ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/391
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-android/pull/391
Yeah that might be the same issue with iOS ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-android/pull/391
Yeah, iOS doesn't even care ...
https://github.com/apache/cordova-ios/blob/master/.travis.yml
Windows does 4+6 ( without `nvm` )
https://github.com/apache/cordova-windows/blob/master/.travis.yml
Browser also 4+6
https://github.com/apache/cordova-browser/blob/master/.travis.yml
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/391
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/391
@alsorokin perfect! Yeah no worries, I can do it too. How about let's file an issue for it first and then go from there?
As for this particular PR, today I will attempt to start an emulator in appveyor + travis and run the native cordova-android instrumented tests. That would end up running _all_ the tests we have in cordova-android in CI, on both Windows and Linux, which would be a big win, I think.
Further, I'd like to direct people to the original issue thread where I commented about how we can speed up the integration tests (by removing a bunch of the create tests). Still looking for feedback on that - if you have an opinion (either for or against it), please speak up!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/391
Might be tough as we tell travis to use the Android image preset via `language: android` so it comes pre-installed with some bits from the Android SDK...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...
Posted by alsorokin <gi...@git.apache.org>.
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-android/pull/391
Take a look at this: http://austinpray.com/ops/2015/09/20/change-travis-node-version.html
So, we're basically download nvm and pass it a node version stored in the environment variable.
I've already done it for the plugins repos (only node 4.2 so far though):
https://github.com/apache/cordova-plugin-device/blob/master/.travis.yml#L55
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org