[GitHub] tajo pull request: TAJO-948: 'INSERT INTO' statement to non existe...

[hyunsik <gi...@git.apache.org>]

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/142#discussion_r17604055
  
    --- Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java ---
    @@ -254,6 +254,10 @@ public Expr visitInsert(Context context, Stack<Expr> stack, Insert expr) throws
               }
     
               TableDesc table = catalog.getTableDesc(qualifiedName);
    +          if (table == null) {
    +            context.state.addVerification("It seems target table doesn't exist");
    --- End diff --
    
    The bug fix looks correct. But, I have one suggestion about the message. The other similar cases use ```relation "%s" does not exist```. Could you change the message for consistency?
    
    You can see the similar case at https://github.com/eminency/tajo/blob/TAJO-948/tajo-core/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java#L134


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---