You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/11 12:08:38 UTC
[GitHub] [skywalking-agent-test-tool] dengliming opened a new pull request #19: Configure ports using a common configuration class instead of a hard-coded configuration
dengliming opened a new pull request #19:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] dengliming commented on pull request #19: Configure ports using a common configuration class instead of a hard-coded configuration
Posted by GitBox <gi...@apache.org>.
dengliming commented on pull request #19:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/19#issuecomment-657056557
> From codes level, it should be fine to provide config. Could you share why you need this?
Thanks for quick reply. I found that these two places can share the port configuration.
```
NettyServerBuilder.forAddress(LocalAddress.ANY)
.forPort(19876)
```
org.apache.skywalking.plugin.test.mockcollector.service.GrpcAddressHttpService#doPost
```
JsonArray jsonArray = new JsonArray();
jsonArray.add(ConfigReader.getGrpcBindHost() + ":" + ConfigReader.getGrpcBindPort());
```
And just a little advice. I can turn it off if it doesn't make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] dengliming closed pull request #19: Configure ports using a common configuration class instead of a hard-coded configuration
Posted by GitBox <gi...@apache.org>.
dengliming closed pull request #19:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] wu-sheng commented on pull request #19: Configure ports using a common configuration class instead of a hard-coded configuration
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #19:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/19#issuecomment-657055781
From codes level, it should be fine to provide config. Could you share why you need this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] wu-sheng commented on pull request #19: Configure ports using a common configuration class instead of a hard-coded configuration
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #19:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/19#issuecomment-657057375
It is fine. I just wonder whether there is any issue locally. Let's wait @dmsolr confirmation. He is the project lead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-agent-test-tool] dmsolr commented on pull request #19: Configure ports using a common configuration class instead of a hard-coded configuration
Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #19:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/19#issuecomment-670280588
Sorry, I am so late.
It is harmless. I don't know whether we need it. In my mind, we don't.
However, we can accept this PR if you need it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org